From: "Gustavo F. Padovan" <padovan@profusion.mobi>
To: Suraj Sumangala <suraj@Atheros.com>
Cc: "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Subject: Re: updating unacked_frames counter during retransmission
Date: Fri, 4 Mar 2011 21:53:09 -0300 [thread overview]
Message-ID: <20110305005309.GB9005@joana> (raw)
In-Reply-To: <4D6F358B.9020603@Atheros.com>
Hi Suraj,
* Suraj Sumangala <suraj@Atheros.com> [2011-03-03 12:00:35 +0530]:
> Hi Gustavo,
>
> I have a question regarding the ERTM implementation.
>
> Should we be incrementing the "l2cap_pinfo.unacked_frames" variable if
> we are retransmitting a frame?
No, if we are retransmitting a frame that means L2CAP didn't received an ack
for it and we are already accounting it in unacked_frames and there is no need
to increment unacked_frames in this case.
>
> Won't this cause the same frame to be accounted twice?
>
> If there are too many retransmissions, will there be a chance that
> "unacked_frames" could cross 0xFF and over flow.
No, unacked_frames number is limited by the remote transmission window size.
--
Gustavo F. Padovan
http://profusion.mobi
next prev parent reply other threads:[~2011-03-05 0:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-03 6:30 updating unacked_frames counter during retransmission Suraj Sumangala
2011-03-05 0:53 ` Gustavo F. Padovan [this message]
2011-03-05 8:51 ` Suraj Sumangala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110305005309.GB9005@joana \
--to=padovan@profusion.mobi \
--cc=linux-bluetooth@vger.kernel.org \
--cc=suraj@Atheros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox