Linux bluetooth development
 help / color / mirror / Atom feed
From: Johan Hedberg <johan.hedberg@gmail.com>
To: Marco Sinigaglia <marco.sinigaglia@csr.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v2] Adjust timeout LE and API
Date: Thu, 10 Mar 2011 11:18:26 +0200	[thread overview]
Message-ID: <20110310091826.GB5566@jh-x301> (raw)
In-Reply-To: <1299689985-6818-1-git-send-email-marco.sinigaglia@csr.com>

Hi Marco,

On Wed, Mar 09, 2011, Marco Sinigaglia wrote:
> 
> The timeout value has been hardcoded on hci_send_req call and, instead, it should be passed from above (for ex from hci_le_set_scan_enable).
> This patch removes the hardcoded value from hci_send_req and it increases the timeout to 1000ms.
> 
> v1-->v2: used git-format-patch
> 
> Signed-off-by: Marco Sinigaglia <marco.sinigaglia@csr.com>
> 
> ---
>  lib/hci.c         |   12 ++++++------
>  lib/hci_lib.h     |    6 +++---
>  tools/hciconfig.c |    2 +-
>  tools/hcitool.c   |    6 +++---
>  4 files changed, 13 insertions(+), 13 deletions(-)

The patch finally applies and has been pushed upstream. However, I did
have to fix your commit message manually:

- Lines should be short enough to fit git log output on a 80
  column wide terminal
- Patch version changes do not belong in the commit message. Put them
  between the "---" and the "diff" line.
- No Signed-off-by line for user space patches

Johan

      reply	other threads:[~2011-03-10  9:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-09 16:59 [PATCH v2] Adjust timeout LE and API Marco Sinigaglia
2011-03-10  9:18 ` Johan Hedberg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110310091826.GB5566@jh-x301 \
    --to=johan.hedberg@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=marco.sinigaglia@csr.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox