Re: [PATCH 2/4] Add actual service for Message Access Profile

[Johan Hedberg <johan.hedberg@gmail.com>]

Hi Slawek,

On Wed, Mar 02, 2011, lkslawek@gmail.com wrote:
> +	ret = obex_get_stream_start(os, name);
> +	if (ret < 0)
> +		goto fail;
> +
> +	return 0;
> +fail:
> +	return ret;
> +}

How about just "return obex_get_stream_start(os, name);"?

> +	ret = obex_put_stream_start(os, name);
> +	if (ret < 0)
> +		goto fail;
> +
> +	return 0;
> +fail:
> +	return ret;
> +}

Same here.

> +	}
> +
> +	return 0;
> +}
> +static struct obex_service_driver mas = {

Missing empty line before "statis struct ...".

>  static int mas_init(void)
>  {
> +	int err;
> +
> +	err = obex_service_driver_register(&mas);
> +	if (err < 0)
> +		goto fail_mas_reg;
> +
>  	return 0;
> +
> +fail_mas_reg:
> +	return err;
>  }

Just "return obex_service_driver_register(&mas);" should be enough.

Johan