* [2.6.38-rc8, patch] fix hci_dev_list locking
@ 2011-03-08 16:07 Daniel J Blueman
2011-03-12 1:47 ` Gustavo F. Padovan
0 siblings, 1 reply; 4+ messages in thread
From: Daniel J Blueman @ 2011-03-08 16:07 UTC (permalink / raw)
To: Linux Kernel, linux-bluetooth
No response from original post, and it missed getting taken into -rc7
and -rc8, so repost:
Release acquired lock on error path, fixing potential hang up.
Signed-off-by: Daniel J Blueman <daniel.blueman@gmail.com>
diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c
index f827fd9..ace8726 100644
--- a/net/bluetooth/mgmt.c
+++ b/net/bluetooth/mgmt.c
@@ -111,8 +111,10 @@ static int read_index_list(struct sock *sk)
body_len = sizeof(*ev) + sizeof(*rp) + (2 * count);
skb = alloc_skb(sizeof(*hdr) + body_len, GFP_ATOMIC);
- if (!skb)
+ if (!skb) {
+ read_unlock(&hci_dev_list_lock);
return -ENOMEM;
+ }
hdr = (void *) skb_put(skb, sizeof(*hdr));
hdr->opcode = cpu_to_le16(MGMT_EV_CMD_COMPLETE);--
--
Daniel J Blueman
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [2.6.38-rc8, patch] fix hci_dev_list locking
2011-03-08 16:07 [2.6.38-rc8, patch] fix hci_dev_list locking Daniel J Blueman
@ 2011-03-12 1:47 ` Gustavo F. Padovan
2011-03-13 3:59 ` Daniel J Blueman
0 siblings, 1 reply; 4+ messages in thread
From: Gustavo F. Padovan @ 2011-03-12 1:47 UTC (permalink / raw)
To: Daniel J Blueman; +Cc: Linux Kernel, linux-bluetooth
Hi Daniel,
* Daniel J Blueman <daniel.blueman@gmail.com> [2011-03-09 00:07:54 +0800]:
> No response from original post, and it missed getting taken into -rc7
> and -rc8, so repost:
>
> Release acquired lock on error path, fixing potential hang up.
I already have a patch like this one in my tree, thanks anyway. :)
--
Gustavo F. Padovan
http://profusion.mobi
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [2.6.38-rc8, patch] fix hci_dev_list locking
2011-03-12 1:47 ` Gustavo F. Padovan
@ 2011-03-13 3:59 ` Daniel J Blueman
2011-03-14 18:04 ` Gustavo F. Padovan
0 siblings, 1 reply; 4+ messages in thread
From: Daniel J Blueman @ 2011-03-13 3:59 UTC (permalink / raw)
To: Gustavo F. Padovan; +Cc: Linux Kernel, linux-bluetooth
Hi Gustavo,
On 12 March 2011 09:47, Gustavo F. Padovan <padovan@profusion.mobi> wrote:
> Hi Daniel,
>
> * Daniel J Blueman <daniel.blueman@gmail.com> [2011-03-09 00:07:54 +0800]:
>
>> No response from original post, and it missed getting taken into -rc7
>> and -rc8, so repost:
>>
>> Release acquired lock on error path, fixing potential hang up.
>
> I already have a patch like this one in my tree, thanks anyway. :)
I guess I'm not looking in the right public tree, but I still couldn't
detect the fix in:
http://git.kernel.org/?p=linux/kernel/git/padovan/bluetooth-2.6.git
or:
http://git.kernel.org/?p=linux/kernel/git/padovan/bluetooth-next-2.6.git
Thanks,
Daniel
--
Daniel J Blueman
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [2.6.38-rc8, patch] fix hci_dev_list locking
2011-03-13 3:59 ` Daniel J Blueman
@ 2011-03-14 18:04 ` Gustavo F. Padovan
0 siblings, 0 replies; 4+ messages in thread
From: Gustavo F. Padovan @ 2011-03-14 18:04 UTC (permalink / raw)
To: Daniel J Blueman; +Cc: Linux Kernel, linux-bluetooth
Hi Daniel,
* Daniel J Blueman <daniel.blueman@gmail.com> [2011-03-13 11:59:27 +0800]:
> Hi Gustavo,
>
> On 12 March 2011 09:47, Gustavo F. Padovan <padovan@profusion.mobi> wrote:
> > Hi Daniel,
> >
> > * Daniel J Blueman <daniel.blueman@gmail.com> [2011-03-09 00:07:54 +0800]:
> >
> >> No response from original post, and it missed getting taken into -rc7
> >> and -rc8, so repost:
> >>
> >> Release acquired lock on error path, fixing potential hang up.
> >
> > I already have a patch like this one in my tree, thanks anyway. :)
>
> I guess I'm not looking in the right public tree, but I still couldn't
> detect the fix in:
> http://git.kernel.org/?p=linux/kernel/git/padovan/bluetooth-2.6.git
> or:
> http://git.kernel.org/?p=linux/kernel/git/padovan/bluetooth-next-2.6.git
On bluetooth-next:
commit b2c60d42db0fea1e6c4345739601024863566a13
Author: Jesper Juhl <jj@chaosbits.net>
Date: Fri Jan 14 00:18:49 2011 +0100
Bluetooth: Fix failure to release lock in read_index_list()
If alloc_skb() fails in read_index_list() we'll return -ENOMEM without
releasing 'hci_dev_list_lock'.
Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Signed-off-by: Gustavo F. Padovan <padovan@profusion.mobi>
--
Gustavo F. Padovan
http://profusion.mobi
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-03-14 18:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-08 16:07 [2.6.38-rc8, patch] fix hci_dev_list locking Daniel J Blueman
2011-03-12 1:47 ` Gustavo F. Padovan
2011-03-13 3:59 ` Daniel J Blueman
2011-03-14 18:04 ` Gustavo F. Padovan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).