From: Johan Hedberg <johan.hedberg@gmail.com>
To: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v3 3/5] Use new UUID functions in GATT
Date: Tue, 15 Mar 2011 10:52:05 +0200 [thread overview]
Message-ID: <20110315085205.GB16296@jh-x301> (raw)
In-Reply-To: <1300128839-6293-4-git-send-email-epx@signove.com>
Hi Elvis,
On Mon, Mar 14, 2011, Elvis Pf??tzenreuter wrote:
> This patch puts the new UUID functions into use for GATT-related
> code, and adds some convenience functions to ATT API (att.h).
> ---
> attrib/att.c | 47 +++++++++++--------------
> attrib/att.h | 69 +++++++++++++++++++++++++++++++++----
> attrib/client.c | 26 ++++++--------
> attrib/gatt.c | 68 +++++++++++++++++++------------------
> attrib/gatt.h | 4 +-
> attrib/gattrib.c | 3 +-
> attrib/gatttool.c | 18 ++++-----
> attrib/interactive.c | 22 +++++------
> attrib/utils.c | 1 +
> src/adapter.c | 1 +
> src/attrib-server.c | 93 +++++++++++++++++++++++++------------------------
> src/attrib-server.h | 4 +-
> src/device.c | 1 +
> src/main.c | 1 +
This one doesn't compile at all:
In file included from attrib/example.c:39:
./src/attrib-server.h:28: error: expected declaration specifiers or '...' before 'bt_uuid_t'
./src/attrib-server.h:30: error: expected declaration specifiers or '...' before 'bt_uuid_t'
In file included from attrib/example.c:41:
attrib/att.h:123: error: expected specifier-qualifier-list before 'bt_uuid_t'
In file included from attrib/example.c:41:
attrib/att.h:208: error: expected ')' before 'src'
attrib/att.h:213: error: expected ')' before 'src'
attrib/att.h:218: error: expected ')' before 'src'
attrib/att.h:226: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'att_get_uuid16'
attrib/att.h:235: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'att_get_uuid128'
attrib/att.h:250: error: expected declaration specifiers or '...' before 'bt_uuid_t'
attrib/att.h:253: error: expected declaration specifiers or '...' before 'bt_uuid_t'
attrib/att.h:255: error: expected declaration specifiers or '...' before 'bt_uuid_t'
attrib/att.h:258: error: expected declaration specifiers or '...' before 'bt_uuid_t'
attrib/att.h:262: error: expected declaration specifiers or '...' before 'bt_uuid_t'
attrib/att.h:265: error: expected declaration specifiers or '...' before 'bt_uuid_t'
cc1: warnings being treated as errors
attrib/example.c: In function 'register_attributes':
attrib/example.c:87: error: passing argument 2 of 'attrib_db_add' makes integer from pointer without a cast
./src/attrib-server.h:28: note: expected 'int' but argument is of type 'struct uuid_t *'
...
Please at least do a basic compilation test before submitting patches ;)
Johan
next prev parent reply other threads:[~2011-03-15 8:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-14 18:53 [PATCH v3 0/5] Add new UUID utility functions and use them in GATT Elvis Pfützenreuter
2011-03-14 18:53 ` [PATCH v3 1/5] Add new UUID utility functions Elvis Pfützenreuter
2011-03-14 20:57 ` Brian Gix
2011-03-14 21:59 ` Elvis Pfützenreuter
2011-03-14 22:10 ` [PATCH v3.1 " Elvis Pfützenreuter
2011-03-14 18:53 ` [PATCH v3 2/5] Add more functions for new UUID handling Elvis Pfützenreuter
2011-03-15 8:49 ` Johan Hedberg
2011-03-14 18:53 ` [PATCH v3 3/5] Use new UUID functions in GATT Elvis Pfützenreuter
2011-03-15 8:52 ` Johan Hedberg [this message]
2011-03-15 12:39 ` Elvis Pfützenreuter
2011-03-15 13:05 ` [PATCH v4 1/2] " Elvis Pfützenreuter
2011-03-15 17:39 ` Johan Hedberg
2011-03-15 13:05 ` [PATCH v4 2/2] Add "unit test" for new UUID functions Elvis Pfützenreuter
2011-03-14 18:53 ` [PATCH v3 4/5] Use new UUID functions in example GATT server Elvis Pfützenreuter
2011-03-14 18:53 ` [PATCH v3 5/5] Add "unit test" for new UUID functions Elvis Pfützenreuter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110315085205.GB16296@jh-x301 \
--to=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox