Linux bluetooth development
 help / color / mirror / Atom feed
From: Johan Hedberg <johan.hedberg@nokia.com>
To: Dmitriy Paliy <dmitriy.paliy@nokia.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Add release all sessions when adapter is switched off
Date: Tue, 22 Mar 2011 12:43:55 +0200	[thread overview]
Message-ID: <20110322104355.GC28726@jh-x301> (raw)
In-Reply-To: <1300721959-5913-1-git-send-email-dmitriy.paliy@nokia.com>

Hi Dmitriy,

On Mon, Mar 21, 2011, Dmitriy Paliy wrote:
> All sessions should be released when adapter is switched off. Then a new
> RequestSession method call always results in change from power off to power
> on such ensuring operational mode. Otherwise, it is possible to end up in
> adapter state being powered off after RequestSession succeded.
> ---
>  src/adapter.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/src/adapter.c b/src/adapter.c
> index cc4f43e..f1c0e2a 100644
> --- a/src/adapter.c
> +++ b/src/adapter.c
> @@ -2507,6 +2507,10 @@ static void set_mode_complete(struct btd_adapter *adapter)
>  
>  	DBG("");
>  
> +	if (adapter->mode == MODE_OFF)
> +		g_slist_foreach(adapter->mode_sessions, (GFunc)  session_free,
> +									NULL);
> +

Don't you have to do g_slist_free() and adapter->mode_sessions = NULL
too? Oh, and you've got two spaces between (GFunc) and session_free :)

Johan

  reply	other threads:[~2011-03-22 10:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-21 15:39 [PATCH] Add release all sessions when adapter is switched off Dmitriy Paliy
2011-03-22 10:43 ` Johan Hedberg [this message]
  -- strict thread matches above, loose matches on Subject: below --
2011-03-22 11:46 [PATCH 0/1 v2] " Dmitriy Paliy
2011-03-22 11:46 ` [PATCH] " Dmitriy Paliy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110322104355.GC28726@jh-x301 \
    --to=johan.hedberg@nokia.com \
    --cc=dmitriy.paliy@nokia.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox