Linux bluetooth development
 help / color / mirror / Atom feed
From: Johan Hedberg <johan.hedberg@gmail.com>
To: Claudio Takahasi <claudio.takahasi@openbossa.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Remove unused fields in btd_driver_data struct
Date: Tue, 22 Mar 2011 23:10:36 +0200	[thread overview]
Message-ID: <20110322211036.GA7180@jh-x301> (raw)
In-Reply-To: <1300827396-8043-1-git-send-email-claudio.takahasi@openbossa.org>

Hi Claudio,

On Tue, Mar 22, 2011, Claudio Takahasi wrote:
> ---
>  src/device.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/src/device.c b/src/device.c
> index e9d9e65..5121064 100644
> --- a/src/device.c
> +++ b/src/device.c
> @@ -68,9 +68,7 @@
>  #define GLOBAL_TRUST "[all]"
>  
>  struct btd_driver_data {
> -	guint id;
>  	struct btd_device_driver *driver;
> -	void *priv;
>  };

Why is btd_driver_data needed at all if btd_device_driver is the only
thing that it contains (i.e. why can't places pointing to
btd_driver_data just point to btd_device_driver directly)?

Johan

  reply	other threads:[~2011-03-22 21:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-22 20:56 [PATCH] Remove unused fields in btd_driver_data struct Claudio Takahasi
2011-03-22 21:10 ` Johan Hedberg [this message]
2011-03-22 21:36   ` Claudio Takahasi
2011-03-23 12:20     ` [PATCH 1/2] Remove unnecessary " Claudio Takahasi
2011-03-23 13:24       ` Johan Hedberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110322211036.GA7180@jh-x301 \
    --to=johan.hedberg@gmail.com \
    --cc=claudio.takahasi@openbossa.org \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox