From: Johan Hedberg <johan.hedberg@gmail.com>
To: Andre Dieb Martins <andre.dieb@signove.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 1/5] Inline ATT dump functions
Date: Thu, 24 Mar 2011 11:24:52 +0200 [thread overview]
Message-ID: <20110324092452.GE30621@jh-x301> (raw)
In-Reply-To: <1300891601-11412-1-git-send-email-andre.dieb@signove.com>
Hi André,
On Wed, Mar 23, 2011, Andre Dieb Martins wrote:
> ---
> parser/att.c | 32 ++++++++++++++++----------------
> 1 files changed, 16 insertions(+), 16 deletions(-)
Do you have some measurements that show that inlining actually has a
noticable effect? You're also missing the justification for this change
in the commit message.
Johan
next prev parent reply other threads:[~2011-03-24 9:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-23 14:46 [PATCH 1/5] Inline ATT dump functions Andre Dieb Martins
2011-03-23 14:46 ` [PATCH 2/5] Add parsing for ATT Write Request Andre Dieb Martins
2011-03-23 14:46 ` [PATCH 3/5] Add parsing for ATT Write Command Andre Dieb Martins
2011-03-23 14:46 ` [PATCH 4/5] Add parsing for ATT Signed Write Andre Dieb Martins
2011-03-23 14:46 ` [PATCH 5/5] Fix handle formatting for ATT Handle Notify Andre Dieb Martins
2011-03-24 9:24 ` Johan Hedberg [this message]
2011-03-24 10:22 ` [PATCH 1/5] Inline ATT dump functions André Dieb
2011-03-24 11:11 ` Szymon Janc
2011-03-24 12:59 ` André Dieb
2011-03-24 20:33 ` Gustavo F. Padovan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110324092452.GE30621@jh-x301 \
--to=johan.hedberg@gmail.com \
--cc=andre.dieb@signove.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox