From: Johan Hedberg <johan.hedberg@gmail.com>
To: Szymon Janc <szymon.janc@tieto.com>
Cc: linux-bluetooth@vger.kernel.org,
par-gunnar.p.hjalmdahl@stericsson.com,
henrik.possung@stericsson.com
Subject: Re: [PATCH v6 2/6] Add support for Out of Band (OOB) association model in mgmtops
Date: Fri, 25 Mar 2011 10:30:57 +0200 [thread overview]
Message-ID: <20110325083057.GB30796@jh-x301> (raw)
In-Reply-To: <1300974459-24076-3-git-send-email-szymon.janc@tieto.com>
Hi Szymon,
On Thu, Mar 24, 2011, Szymon Janc wrote:
> @@ -1132,6 +1185,10 @@ static void mgmt_cmd_status(int sk, uint16_t index, void *buf, size_t len)
> opcode = btohs(bt_get_unaligned(&ev->opcode));
>
> DBG("status %u opcode %u (index %u)", ev->status, opcode, index);
> +
> + if (opcode == MGMT_OP_READ_LOCAL_OOB_DATA)
> + read_local_oob_data_failed(sk, index);
> +
> }
Firstly, unnecessary empty line at the end of the function. Secondly,
since it's likely that we'll have to deal with cmd_status messages for
other commands as well I think it'd make sense to start a swtich
statement here (with just one case entry for now).
Johan
next prev parent reply other threads:[~2011-03-25 8:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-24 13:47 [PATCH v6 0/6] Support for out of band association model Szymon Janc
2011-03-24 13:47 ` [PATCH v6 1/6] Add initial support for Out of Band (OOB) " Szymon Janc
2011-03-25 8:28 ` Johan Hedberg
2011-03-24 13:47 ` [PATCH v6 2/6] Add support for Out of Band (OOB) association model in mgmtops Szymon Janc
2011-03-25 8:30 ` Johan Hedberg [this message]
2011-03-24 13:47 ` [PATCH v6 3/6] Add support for Out of Band (OOB) association model in hciops Szymon Janc
2011-03-25 8:33 ` Johan Hedberg
2011-03-26 11:26 ` Szymon Janc
2011-03-24 13:47 ` [PATCH v6 4/6] Add D-Bus OOB plugin Szymon Janc
2011-03-25 8:54 ` Johan Hedberg
2011-03-24 13:47 ` [PATCH v6 5/6] Update mgmt-api.txt with OOB commands Szymon Janc
2011-03-24 13:47 ` [PATCH v6 6/6] Add oob-api.txt with documentation about OOB D-Bus methods Szymon Janc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110325083057.GB30796@jh-x301 \
--to=johan.hedberg@gmail.com \
--cc=henrik.possung@stericsson.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=par-gunnar.p.hjalmdahl@stericsson.com \
--cc=szymon.janc@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox