From: Johan Hedberg <johan.hedberg@gmail.com>
To: Waldemar.Rymarkiewicz@tieto.com
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v2] Add sap_disconnect_ind interface for sap-sim drivers
Date: Mon, 28 Mar 2011 12:55:57 +0300 [thread overview]
Message-ID: <20110328095557.GA11511@jh-x301> (raw)
In-Reply-To: <99B09243E1A5DA4898CDD8B7001114481085E2325E@EXMB04.eu.tieto.com>
Hi Waldek,
On Mon, Mar 28, 2011, Waldemar.Rymarkiewicz@tieto.com wrote:
> >Are you planning to have some additional Disconnect* method in
> >the future since you didn't reuse the existing "Disconnect"
> >method name for this? The patch is also missing the
> >corresponding update to sap-api.txt.
>
> The Disconnect method mentioned in sap-api.txt is implemented in
> server.c and it's the gracefull disconnect. The one I've changes in
> the patch is used in sap-dummy.c driver, which is used for tests only.
>
> The original idea was to have Disconnect(type) method in server.c, but
> finally, in a discussion, we came to the conclusion that the immediate
> disconnect should not be used by user. Driver should handle this if
> it's needed.
>
> So, sap-api.txt stays unchanged, and dummy-driver is changed to be
> able to pass some of PTS tests.
Ok, sounds fine to me.
Johan
next prev parent reply other threads:[~2011-03-28 9:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-24 16:09 [PATCH] Add sap_disconnect_ind interface for sap-sim drivers Waldemar Rymarkiewicz
2011-03-24 15:08 ` Waldemar.Rymarkiewicz
2011-03-24 16:16 ` [PATCH v2] " Waldemar Rymarkiewicz
2011-03-25 9:17 ` Johan Hedberg
2011-03-28 9:40 ` Waldemar.Rymarkiewicz
2011-03-28 9:55 ` Johan Hedberg [this message]
2011-04-05 13:38 ` Waldemar.Rymarkiewicz
2011-04-09 18:12 ` Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110328095557.GA11511@jh-x301 \
--to=johan.hedberg@gmail.com \
--cc=Waldemar.Rymarkiewicz@tieto.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox