From: "Gustavo F. Padovan" <padovan@profusion.mobi>
To: Ville Tervo <ville.tervo@nokia.com>
Cc: linux-bluetooth@vger.kernel.org, johan.hedberg@nokia.com
Subject: Re: [PATCH] Bluetooth: Fix refcount balance for hci connection
Date: Mon, 11 Apr 2011 15:34:27 -0300 [thread overview]
Message-ID: <20110411183427.GC2195@joana> (raw)
In-Reply-To: <1302177590-4107-1-git-send-email-ville.tervo@nokia.com>
Hi Ville,
* Ville Tervo <ville.tervo@nokia.com> [2011-04-07 14:59:50 +0300]:
> hci_io_capa_reply_evt() holds reference for hciconnection. It's useless since
> hci_io_capa_request_evt()/hci_simple_pair_complete_evt() already protects the
> connection. In addition it leaves connection open after failed SSP pairing.
>
> Signed-off-by: Ville Tervo <ville.tervo@nokia.com>
> ---
> net/bluetooth/hci_event.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c
> index 7a3398d..6b878c8 100644
> --- a/net/bluetooth/hci_event.c
> +++ b/net/bluetooth/hci_event.c
> @@ -2419,8 +2419,6 @@ static inline void hci_io_capa_reply_evt(struct hci_dev *hdev, struct sk_buff *s
> if (!conn)
> goto unlock;
>
> - hci_conn_hold(conn);
> -
Patch has been applied, thanks.
--
Gustavo F. Padovan
http://profusion.mobi
prev parent reply other threads:[~2011-04-11 18:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-07 11:59 [PATCH] Bluetooth: Fix refcount balance for hci connection Ville Tervo
2011-04-11 18:34 ` Gustavo F. Padovan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110411183427.GC2195@joana \
--to=padovan@profusion.mobi \
--cc=johan.hedberg@nokia.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=ville.tervo@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).