* [PATCH] Bluetooth: Fix refcount balance for hci connection
@ 2011-04-07 11:59 Ville Tervo
2011-04-11 18:34 ` Gustavo F. Padovan
0 siblings, 1 reply; 2+ messages in thread
From: Ville Tervo @ 2011-04-07 11:59 UTC (permalink / raw)
To: linux-bluetooth; +Cc: johan.hedberg, Ville Tervo
hci_io_capa_reply_evt() holds reference for hciconnection. It's useless since
hci_io_capa_request_evt()/hci_simple_pair_complete_evt() already protects the
connection. In addition it leaves connection open after failed SSP pairing.
Signed-off-by: Ville Tervo <ville.tervo@nokia.com>
---
net/bluetooth/hci_event.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c
index 7a3398d..6b878c8 100644
--- a/net/bluetooth/hci_event.c
+++ b/net/bluetooth/hci_event.c
@@ -2419,8 +2419,6 @@ static inline void hci_io_capa_reply_evt(struct hci_dev *hdev, struct sk_buff *s
if (!conn)
goto unlock;
- hci_conn_hold(conn);
-
conn->remote_cap = ev->capability;
conn->remote_oob = ev->oob_data;
conn->remote_auth = ev->authentication;
--
1.7.2.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Bluetooth: Fix refcount balance for hci connection
2011-04-07 11:59 [PATCH] Bluetooth: Fix refcount balance for hci connection Ville Tervo
@ 2011-04-11 18:34 ` Gustavo F. Padovan
0 siblings, 0 replies; 2+ messages in thread
From: Gustavo F. Padovan @ 2011-04-11 18:34 UTC (permalink / raw)
To: Ville Tervo; +Cc: linux-bluetooth, johan.hedberg
Hi Ville,
* Ville Tervo <ville.tervo@nokia.com> [2011-04-07 14:59:50 +0300]:
> hci_io_capa_reply_evt() holds reference for hciconnection. It's useless since
> hci_io_capa_request_evt()/hci_simple_pair_complete_evt() already protects the
> connection. In addition it leaves connection open after failed SSP pairing.
>
> Signed-off-by: Ville Tervo <ville.tervo@nokia.com>
> ---
> net/bluetooth/hci_event.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c
> index 7a3398d..6b878c8 100644
> --- a/net/bluetooth/hci_event.c
> +++ b/net/bluetooth/hci_event.c
> @@ -2419,8 +2419,6 @@ static inline void hci_io_capa_reply_evt(struct hci_dev *hdev, struct sk_buff *s
> if (!conn)
> goto unlock;
>
> - hci_conn_hold(conn);
> -
Patch has been applied, thanks.
--
Gustavo F. Padovan
http://profusion.mobi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-04-11 18:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-07 11:59 [PATCH] Bluetooth: Fix refcount balance for hci connection Ville Tervo
2011-04-11 18:34 ` Gustavo F. Padovan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).