From: Johan Hedberg <johan.hedberg@gmail.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: "Gustavo F. Padovan" <padovan@profusion.mobi>,
Claudio Takahasi <claudio.takahasi@openbossa.org>,
linux-bluetooth@vger.kernel.org
Subject: Re: [RFC] Proposal to distinguish address device types
Date: Sat, 16 Apr 2011 10:00:06 +0300 [thread overview]
Message-ID: <20110416070006.GA10860@jh-x301> (raw)
In-Reply-To: <1302915790.2503.31.camel@aeonflux>
Hi Marcel,
On Fri, Apr 15, 2011, Marcel Holtmann wrote:
> > > + BDADDR_TYPE_LE_PUBLIC,
> > > + BRADDR_TYPE_LE_RANDOM
> > > +};
>
> I am also not sure the we should have this BR/EDR differentiation since
> the specification only talks about public and random addresses. And we
> should follow the specification type value here. I am against
> introducing our enum here.
The HCI specification only has values for public and random because
everywhere they are used it is already clear from the context (the HCI
command or event in question) if we're talking about LE or BR/EDR. We on
the other hand don't have this contextual information with the
mgmt_pair_device command. Saying "public" there could mean both BR/EDR
public or LE public, i.e. an enum with just two possible values is not
going to be of much use to us. Because of this difference between our
API and that of HCI I don't think it's fair to apply the HCI
convention/restriction to us.
Johan
next prev parent reply other threads:[~2011-04-16 7:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-15 18:33 [RFC] Proposal to distinguish address device types Claudio Takahasi
2011-04-15 18:47 ` Gustavo F. Padovan
2011-04-16 1:03 ` Marcel Holtmann
2011-04-16 7:00 ` Johan Hedberg [this message]
2011-04-16 17:04 ` Claudio Takahasi
2011-04-18 18:20 ` Claudio Takahasi
2011-05-30 17:27 ` Luiz Augusto von Dentz
2011-06-01 19:03 ` Gustavo F. Padovan
2011-06-01 20:00 ` Anderson Briglia
2011-06-02 1:16 ` Marcel Holtmann
2011-06-02 13:05 ` [RFC] PrJohan Hedbergoposal " tim.howes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110416070006.GA10860@jh-x301 \
--to=johan.hedberg@gmail.com \
--cc=claudio.takahasi@openbossa.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=padovan@profusion.mobi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox