* [PATCH] Bluetooth: Only keeping SAR bits when retransmitting one frame.
@ 2011-04-18 3:04 Ruiyi Zhang
2011-04-18 17:53 ` Gustavo F. Padovan
0 siblings, 1 reply; 2+ messages in thread
From: Ruiyi Zhang @ 2011-04-18 3:04 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Ruiyi Zhang
When retrasmitting one frame, only SAR bits in control field should
be kept.
Signed-off-by: Ruiyi Zhang <Ruiyi.zhang@atheros.com>
---
net/bluetooth/l2cap_core.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c
index ca27f3a..2c8dd44 100644
--- a/net/bluetooth/l2cap_core.c
+++ b/net/bluetooth/l2cap_core.c
@@ -1051,6 +1051,7 @@ static void l2cap_retransmit_one_frame(struct sock *sk, u8 tx_seq)
tx_skb = skb_clone(skb, GFP_ATOMIC);
bt_cb(skb)->retries++;
control = get_unaligned_le16(tx_skb->data + L2CAP_HDR_SIZE);
+ control &= L2CAP_CTRL_SAR;
if (pi->conn_state & L2CAP_CONN_SEND_FBIT) {
control |= L2CAP_CTRL_FINAL;
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Bluetooth: Only keeping SAR bits when retransmitting one frame.
2011-04-18 3:04 [PATCH] Bluetooth: Only keeping SAR bits when retransmitting one frame Ruiyi Zhang
@ 2011-04-18 17:53 ` Gustavo F. Padovan
0 siblings, 0 replies; 2+ messages in thread
From: Gustavo F. Padovan @ 2011-04-18 17:53 UTC (permalink / raw)
To: Ruiyi Zhang; +Cc: linux-bluetooth
Hi Ruiyi,
* Ruiyi Zhang <Ruiyi.zhang@atheros.com> [2011-04-18 11:04:30 +0800]:
> When retrasmitting one frame, only SAR bits in control field should
> be kept.
>
> Signed-off-by: Ruiyi Zhang <Ruiyi.zhang@atheros.com>
> ---
> net/bluetooth/l2cap_core.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
Good catch! Applied, thanks.
--
Gustavo F. Padovan
http://profusion.mobi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-04-18 17:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-18 3:04 [PATCH] Bluetooth: Only keeping SAR bits when retransmitting one frame Ruiyi Zhang
2011-04-18 17:53 ` Gustavo F. Padovan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).