From: Johan Hedberg <johan.hedberg@gmail.com>
To: Anderson Briglia <anderson.briglia@openbossa.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 1/2] Bluetooth: Add basic discovery commands to the management interface
Date: Wed, 20 Apr 2011 16:09:44 +0300 [thread overview]
Message-ID: <20110420130944.GA3519@jh-x301> (raw)
In-Reply-To: <BANLkTik5UF9hPgHG1hwzWV2hG5ZLS8GXnQ@mail.gmail.com>
Hi,
On Wed, Apr 20, 2011, Anderson Briglia wrote:
> you had already sent this few weeks ago.
Could you point me to that thread? I'm not aware of sending these
patches before. AFAIK they were only available in my kernel.org tree
(which I use for experimental stuff not yet ready for upstream).
> What do you prefer? I modify the commit message and the patch
> authoring (and send it again)?
As I said, the changes are probably too minor to justify an author
change. My main point was that don't send stuff in other peoples name
without talking to them first.
> Which coding style issues did you notice?
Minor things like adding an extra empty line at the end of both patches
(shouldn't checkpatch.pl complain about that?) and an extra space in the
format string of a BT_DBG("hci%u ", index) debug print in the first patch.
Johan
next prev parent reply other threads:[~2011-04-20 13:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-19 21:35 [PATCH 1/2] Bluetooth: Add basic discovery commands to the management interface anderson.briglia
2011-04-19 21:58 ` Johan Hedberg
2011-04-20 12:33 ` Anderson Briglia
2011-04-20 13:09 ` Johan Hedberg [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-04-22 0:00 anderson.briglia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110420130944.GA3519@jh-x301 \
--to=johan.hedberg@gmail.com \
--cc=anderson.briglia@openbossa.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).