From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <cyrus@holtmann.org>
Date: Wed, 27 Apr 2011 16:57:23 -0700
From: Johan Hedberg <johan.hedberg@gmail.com>
To: Anderson Lizardo <anderson.lizardo@openbossa.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 7/7] Bluetooth: Fix link key persistent storage criteria
Message-ID: <20110427235723.GA3378@jh-x301>
References: <1303945480-25756-1-git-send-email-johan.hedberg@gmail.com>
 <1303945480-25756-7-git-send-email-johan.hedberg@gmail.com>
 <BANLkTikpQZ9MLvfnCH7oDMN2+_+M=M-QNQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
In-Reply-To: <BANLkTikpQZ9MLvfnCH7oDMN2+_+M=M-QNQ@mail.gmail.com>
Sender: linux-bluetooth-owner@vger.kernel.org
List-ID: <linux-bluetooth.vger.kernel.org>

Hi Lizardo,

On Wed, Apr 27, 2011, Anderson Lizardo wrote:
> > +       if (new_key && !hci_persistent_key(hdev, conn, type, old_key_type)) {
> > +               list_del(&key->list);
> > +               kfree(key);
> > +               return 0;
> 
> Just to make sure, is this condition possible?
> 
> * new_key parameter not zero
> * old_key variable not NULL
> 
> If so, "key" will point to an entry from hdev->link_keys , which will
> be freed on the if() above without removing it from the list.

Do you see the list_del call there? :)

Johan