linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Gustavo F. Padovan" <padovan@profusion.mobi>
To: Anderson Briglia <anderson.briglia@openbossa.org>
Cc: "Elvis Pfützenreuter" <epx@signove.com>,
	"Johan Hedberg" <johan.hedberg@gmail.com>,
	linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Remove btio.c compilation warning
Date: Mon, 2 May 2011 18:47:28 -0300	[thread overview]
Message-ID: <20110502214728.GD2364@joana> (raw)
In-Reply-To: <BANLkTiknmT4JDXxbB0RQcraoAvo2ueY9ng@mail.gmail.com>

Hi Briglia,

* Anderson Briglia <anderson.briglia@openbossa.org> [2011-05-02 18:33:11 -0300]:

> Hi all,
> 
> On Mon, May 2, 2011 at 6:23 PM, Elvis Pfützenreuter <epx@signove.com> wrote:
> > On May 2, 2011, at 6:15 PM, Johan Hedberg wrote:
> >
> >> Hi Briglia,
> >>
> >> On Mon, May 02, 2011, anderson.briglia@openbossa.org wrote:
> >>> This patch fixes a compilation warning regarding btio/btio.c
> >>> compilation.
> >>> ---
> >>> btio/btio.c |    2 +-
> >>> 1 files changed, 1 insertions(+), 1 deletions(-)
> >>>
> >>> diff --git a/btio/btio.c b/btio/btio.c
> >>> index 6d71b90..8f166cc 100644
> >>> --- a/btio/btio.c
> >>> +++ b/btio/btio.c
> >>> @@ -800,7 +800,7 @@ static gboolean l2cap_get(int sock, GError **err, BtIOOption opt1,
> >>>      uint8_t dev_class[3];
> >>>      uint16_t handle;
> >>>      socklen_t len;
> >>> -    gboolean flushable;
> >>> +    gboolean flushable = TRUE;
> >>>
> >>>      len = sizeof(l2o);
> >>>      memset(&l2o, 0, len);
> >>
> >> I don't get the warning with my compiler, so in addition to the already
> >> requested compiler logs please also mention the compiler version. Also,
> >> the value should default to FALSE and not TRUE.
> 
> >
> > It looks like a false alarm from gcc 4.5.2 (Ubuntu Natty), or at least I feel
> > like it (got it here, too). If you agree, a bug ticket could be submitted to them.
> 
> It makes sense. This "fake" warning appears after I upgraded to Ubuntu
> Natty. Anyway, you guys could make a quick test adding
> --enable-maintainer-mode flag to configure.

We always have maintainer mode enabled and I can't see anything wrong here. It's
probably your ubuntu. 

-- 
Gustavo F. Padovan
http://profusion.mobi

  reply	other threads:[~2011-05-02 21:47 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-02 20:43 [PATCH] Remove btio.c compilation warning anderson.briglia
2011-05-02 20:56 ` Antonio Ospite
2011-05-02 21:15 ` Johan Hedberg
2011-05-02 21:23   ` Elvis Pfützenreuter
2011-05-02 21:33     ` Anderson Briglia
2011-05-02 21:47       ` Gustavo F. Padovan [this message]
2011-05-04 21:39 ` Johan Hedberg
2011-05-04 23:09   ` Anderson Briglia
2011-05-04 23:23     ` Elvis Pfützenreuter
2011-05-05  8:05       ` Luiz Augusto von Dentz
2011-05-05 14:05         ` Vinicius Costa Gomes
2011-05-05 14:30           ` Luiz Augusto von Dentz
2011-05-05 18:51             ` Anderson Briglia
2011-05-05 19:01           ` Bastien Nocera

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110502214728.GD2364@joana \
    --to=padovan@profusion.mobi \
    --cc=anderson.briglia@openbossa.org \
    --cc=epx@signove.com \
    --cc=johan.hedberg@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).