From: Johan Hedberg <johan.hedberg@gmail.com>
To: anderson.briglia@openbossa.org
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Remove btio.c compilation warning
Date: Thu, 5 May 2011 00:39:36 +0300 [thread overview]
Message-ID: <20110504213936.GA22493@jh-x301> (raw)
In-Reply-To: <4dbf1776.0bd9650a.1733.7e99@mx.google.com>
Hi,
On Mon, May 02, 2011, anderson.briglia@openbossa.org wrote:
> This patch fixes a compilation warning regarding btio/btio.c
> compilation.
> ---
> btio/btio.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/btio/btio.c b/btio/btio.c
> index 6d71b90..8f166cc 100644
> --- a/btio/btio.c
> +++ b/btio/btio.c
> @@ -800,7 +800,7 @@ static gboolean l2cap_get(int sock, GError **err, BtIOOption opt1,
> uint8_t dev_class[3];
> uint16_t handle;
> socklen_t len;
> - gboolean flushable;
> + gboolean flushable = TRUE;
>
> len = sizeof(l2o);
> memset(&l2o, 0, len);
So are we going to get an updated patch for this (with the modifications
that were requested)? It's quite clearly a false positive by the
compiler (i.e. a compiler bug) but I still think that we should try to
keep the BlueZ tree compilable with "./bootstrap-configure && make" for
all major distributions.
Johan
next prev parent reply other threads:[~2011-05-04 21:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-02 20:43 [PATCH] Remove btio.c compilation warning anderson.briglia
2011-05-02 20:56 ` Antonio Ospite
2011-05-02 21:15 ` Johan Hedberg
2011-05-02 21:23 ` Elvis Pfützenreuter
2011-05-02 21:33 ` Anderson Briglia
2011-05-02 21:47 ` Gustavo F. Padovan
2011-05-04 21:39 ` Johan Hedberg [this message]
2011-05-04 23:09 ` Anderson Briglia
2011-05-04 23:23 ` Elvis Pfützenreuter
2011-05-05 8:05 ` Luiz Augusto von Dentz
2011-05-05 14:05 ` Vinicius Costa Gomes
2011-05-05 14:30 ` Luiz Augusto von Dentz
2011-05-05 18:51 ` Anderson Briglia
2011-05-05 19:01 ` Bastien Nocera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110504213936.GA22493@jh-x301 \
--to=johan.hedberg@gmail.com \
--cc=anderson.briglia@openbossa.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox