From: Vinicius Costa Gomes <vinicius.gomes@openbossa.org>
To: Claudio Takahasi <claudio.takahasi@openbossa.org>,
linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v2 02/13] Add Bluetooth address type definition
Date: Wed, 4 May 2011 21:31:34 -0300 [thread overview]
Message-ID: <20110505003134.GA26302@piper> (raw)
In-Reply-To: <20110504060357.GA3711@jh-x301>
Hi,
On 09:03 Wed 04 May, Johan Hedberg wrote:
> Hi Claudio,
>
> On Tue, May 03, 2011, Claudio Takahasi wrote:
> > Values defined to LE(public and random) are defined in the Bluetooth
> > Core Specification. For basic rate, there isn't address type concept.
> > The constants introduced by this commit will be used to identify the
> > remote address type, basically to distinguish LE/BR devices before
> > to request the L2CAP connection.
> > ---
> > lib/bluetooth.h | 4 ++++
> > 1 files changed, 4 insertions(+), 0 deletions(-)
> >
> > diff --git a/lib/bluetooth.h b/lib/bluetooth.h
> > index 738e07a..98b8f1c 100644
> > --- a/lib/bluetooth.h
> > +++ b/lib/bluetooth.h
> > @@ -130,6 +130,10 @@ typedef struct {
> > #define BDADDR_ALL (&(bdaddr_t) {{0xff, 0xff, 0xff, 0xff, 0xff, 0xff}})
> > #define BDADDR_LOCAL (&(bdaddr_t) {{0, 0, 0, 0xff, 0xff, 0xff}})
> >
> > +#define BDADDR_TYPE_LE_PUBLIC 0x00
> > +#define BRADDR_TYPE_LE_RANDOM 0x01
> > +#define BDADDR_TYPE_BR 0xff
>
> Firstly this still needs Marcel's blessing (though I don't really see
> any other solution than an address type with three possible values).
> Secondly, if this is ever going to be added to the L2CAP socket address
> you'd have to have 0x00 as BDADDR_TYPE_BR for backwards compatibility.
>
As Claudio explained in an earlier email, we will need a way to get the
device type when the connection with that device starts
(MGMT_EV_DEVICE_CONNECTED), with hciops we can infer the type if we receive
the LE Meta Event.
My question is: should the event have a bdaddr_type field or a type field?
> Johan
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Cheers,
--
Vinicius
next prev parent reply other threads:[~2011-05-05 0:31 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-28 22:36 [PATCH 00/13] Discovery Cleanup - Step 1 Claudio Takahasi
2011-04-28 22:36 ` [PATCH 01/13] Move EIR related functions to a new file Claudio Takahasi
2011-05-03 21:32 ` [PATCH v2 " Claudio Takahasi
2011-04-28 22:36 ` [PATCH 02/13] Add Bluetooth address type definition Claudio Takahasi
2011-05-03 21:32 ` [PATCH v2 " Claudio Takahasi
2011-05-04 6:03 ` Johan Hedberg
2011-05-04 11:14 ` Anderson Lizardo
2011-05-05 0:31 ` Vinicius Costa Gomes [this message]
2011-05-12 1:20 ` Marcel Holtmann
2011-05-12 17:55 ` Claudio Takahasi
2011-05-12 19:10 ` Marcel Holtmann
2011-04-28 22:36 ` [PATCH 03/13] Initial device found cleanup Claudio Takahasi
2011-05-03 21:32 ` [PATCH v2 " Claudio Takahasi
2011-04-28 22:37 ` [PATCH 04/13] Move legacy verification to a new function Claudio Takahasi
2011-05-03 21:32 ` [PATCH v2 " Claudio Takahasi
2011-04-28 22:37 ` [PATCH 05/13] Cleanup read name and alias from storage Claudio Takahasi
2011-05-03 21:33 ` [PATCH v2 " Claudio Takahasi
2011-04-28 22:37 ` [PATCH 06/13] Don't resolve name if the name is in the storage Claudio Takahasi
2011-05-03 21:33 ` [PATCH v2 " Claudio Takahasi
2011-04-28 22:37 ` [PATCH 07/13] Unify inquiry results and advertises Claudio Takahasi
2011-05-03 21:33 ` [PATCH v2 " Claudio Takahasi
2011-04-28 22:37 ` [PATCH 08/13] Fix memory leak of EIR data Claudio Takahasi
2011-05-03 21:33 ` [PATCH v2 " Claudio Takahasi
2011-04-28 22:37 ` [PATCH 09/13] Remove btd_event_advertising_report Claudio Takahasi
2011-05-03 21:33 ` [PATCH v2 " Claudio Takahasi
2011-04-28 22:37 ` [PATCH 10/13] Change the order to write/read the remote's name Claudio Takahasi
2011-05-03 21:33 ` [PATCH v2 " Claudio Takahasi
2011-04-28 22:37 ` [PATCH 11/13] Cleanup inserting new device found entry Claudio Takahasi
2011-05-03 21:33 ` [PATCH v2 " Claudio Takahasi
2011-04-28 22:37 ` [PATCH 12/13] Replace EIR_DATA_LENGTH with HCI_MAX_EIR_LENGTH Claudio Takahasi
2011-05-03 21:33 ` [PATCH v2 " Claudio Takahasi
2011-04-28 22:37 ` [PATCH 13/13] Drop variable EIR length Claudio Takahasi
2011-05-03 21:34 ` [PATCH v2 " Claudio Takahasi
2011-04-29 21:07 ` [PATCH 00/13] Discovery Cleanup - Step 1 Claudio Takahasi
2011-05-03 21:32 ` [PATCH v2 " Claudio Takahasi
2011-05-05 8:34 ` Johan Hedberg
2011-05-05 17:34 ` Claudio Takahasi
2011-05-16 20:49 ` [PATCH v3 00/12] Discovery Cleanup Claudio Takahasi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110505003134.GA26302@piper \
--to=vinicius.gomes@openbossa.org \
--cc=claudio.takahasi@openbossa.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).