From: Johan Hedberg <johan.hedberg@gmail.com>
To: Claudio Takahasi <claudio.takahasi@openbossa.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v2 00/13] Discovery Cleanup - Step 1
Date: Thu, 5 May 2011 01:34:17 -0700 [thread overview]
Message-ID: <20110505083417.GB24639@jh-x301> (raw)
In-Reply-To: <1304458330-21499-1-git-send-email-claudio.takahasi@openbossa.org>
Hi Claudio,
On Tue, May 03, 2011, Claudio Takahasi wrote:
> This patch series is the first step to cleanup the device discovery
> procedure. The main changes are:
> - Unify advertising reports and inquiry results: mgmt sends
> one device found event
> - Logic improvement/cleanup: device found
> - Move EIR functions to a new file
> - Add BDADDR type constants: necessary L2CAP connections and bonding
>
>
>
> Bruna Moreira (3):
> Remove btd_event_advertising_report
> Replace EIR_DATA_LENGTH with HCI_MAX_EIR_LENGTH
> Drop variable EIR length
>
> Claudio Takahasi (10):
> Move EIR related functions to a new file
> Add Bluetooth address type definition
> Initial device found cleanup
> Move legacy verification to a new function
> Cleanup read name and alias from storage
> Don't resolve name if the name is in the storage
> Unify inquiry results and advertises
> Fix memory leak of EIR data
> Change the order to write/read the remote's name
> Cleanup inserting new device found entry
>
> Makefile.am | 2 +-
> lib/bluetooth.h | 4 +
> plugins/hciops.c | 202 +++++----------------------------
> plugins/mgmtops.c | 3 +-
> src/adapter.c | 182 +++++++++++++++++++-----------
> src/adapter.h | 9 +-
> src/eir.c | 328 +++++++++++++++++++++++++++++++++++++++++++++++++++++
> src/eir.h | 41 +++++++
> src/event.c | 224 +-----------------------------------
> src/event.h | 5 +-
> src/sdpd.h | 14 ---
> 11 files changed, 530 insertions(+), 484 deletions(-)
> create mode 100644 src/eir.c
> create mode 100644 src/eir.h
These patches don't seem to apply any more after I applied Andrés
patches. (also, I can't really try applying anything else except 1/13
since 2/13 is already the address type patch which is still being
discussed).
Johan
next prev parent reply other threads:[~2011-05-05 8:34 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-28 22:36 [PATCH 00/13] Discovery Cleanup - Step 1 Claudio Takahasi
2011-04-28 22:36 ` [PATCH 01/13] Move EIR related functions to a new file Claudio Takahasi
2011-05-03 21:32 ` [PATCH v2 " Claudio Takahasi
2011-04-28 22:36 ` [PATCH 02/13] Add Bluetooth address type definition Claudio Takahasi
2011-05-03 21:32 ` [PATCH v2 " Claudio Takahasi
2011-05-04 6:03 ` Johan Hedberg
2011-05-04 11:14 ` Anderson Lizardo
2011-05-05 0:31 ` Vinicius Costa Gomes
2011-05-12 1:20 ` Marcel Holtmann
2011-05-12 17:55 ` Claudio Takahasi
2011-05-12 19:10 ` Marcel Holtmann
2011-04-28 22:36 ` [PATCH 03/13] Initial device found cleanup Claudio Takahasi
2011-05-03 21:32 ` [PATCH v2 " Claudio Takahasi
2011-04-28 22:37 ` [PATCH 04/13] Move legacy verification to a new function Claudio Takahasi
2011-05-03 21:32 ` [PATCH v2 " Claudio Takahasi
2011-04-28 22:37 ` [PATCH 05/13] Cleanup read name and alias from storage Claudio Takahasi
2011-05-03 21:33 ` [PATCH v2 " Claudio Takahasi
2011-04-28 22:37 ` [PATCH 06/13] Don't resolve name if the name is in the storage Claudio Takahasi
2011-05-03 21:33 ` [PATCH v2 " Claudio Takahasi
2011-04-28 22:37 ` [PATCH 07/13] Unify inquiry results and advertises Claudio Takahasi
2011-05-03 21:33 ` [PATCH v2 " Claudio Takahasi
2011-04-28 22:37 ` [PATCH 08/13] Fix memory leak of EIR data Claudio Takahasi
2011-05-03 21:33 ` [PATCH v2 " Claudio Takahasi
2011-04-28 22:37 ` [PATCH 09/13] Remove btd_event_advertising_report Claudio Takahasi
2011-05-03 21:33 ` [PATCH v2 " Claudio Takahasi
2011-04-28 22:37 ` [PATCH 10/13] Change the order to write/read the remote's name Claudio Takahasi
2011-05-03 21:33 ` [PATCH v2 " Claudio Takahasi
2011-04-28 22:37 ` [PATCH 11/13] Cleanup inserting new device found entry Claudio Takahasi
2011-05-03 21:33 ` [PATCH v2 " Claudio Takahasi
2011-04-28 22:37 ` [PATCH 12/13] Replace EIR_DATA_LENGTH with HCI_MAX_EIR_LENGTH Claudio Takahasi
2011-05-03 21:33 ` [PATCH v2 " Claudio Takahasi
2011-04-28 22:37 ` [PATCH 13/13] Drop variable EIR length Claudio Takahasi
2011-05-03 21:34 ` [PATCH v2 " Claudio Takahasi
2011-04-29 21:07 ` [PATCH 00/13] Discovery Cleanup - Step 1 Claudio Takahasi
2011-05-03 21:32 ` [PATCH v2 " Claudio Takahasi
2011-05-05 8:34 ` Johan Hedberg [this message]
2011-05-05 17:34 ` Claudio Takahasi
2011-05-16 20:49 ` [PATCH v3 00/12] Discovery Cleanup Claudio Takahasi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110505083417.GB24639@jh-x301 \
--to=johan.hedberg@gmail.com \
--cc=claudio.takahasi@openbossa.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox