From: Greg KH <greg@kroah.com>
To: Linus Walleij <linus.ml.walleij@gmail.com>
Cc: Par-Gunnar Hjalmdahl <par-gunnar.p.hjalmdahl@stericsson.com>,
Greg Kroah-Hartman <gregkh@suse.de>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
linux-bluetooth@vger.kernel.org,
Pavan Savoy <pavan_savoy@sify.com>,
Vitaly Wool <vitalywool@gmail.com>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Arnd Bergmann <arnd@arndb.de>,
Marcel Holtmann <marcel@holtmann.org>,
Lukasz Rymanowski <Lukasz.Rymanowski@tieto.com>,
Par-Gunnar Hjalmdahl <pghatwork@gmail.com>,
Lee Jones <lee.jones@linaro.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>
Subject: Re: [PATCH v6] staging: Add ST-Ericsson CG2900 driver
Date: Tue, 10 May 2011 18:56:50 -0700 [thread overview]
Message-ID: <20110511015650.GA6840@kroah.com> (raw)
In-Reply-To: <BANLkTimimx-pW9mOtb_9yM5XcQ5nOeGYug@mail.gmail.com>
On Wed, May 11, 2011 at 02:07:33AM +0200, Linus Walleij wrote:
> 2011/5/10 Greg KH <greg@kroah.com>:
>
> > On Tue, May 10, 2011 at 05:10:32PM +0200, Par-Gunnar Hjalmdahl wrote:
> >> This patch adds support for the ST-Ericsson CG2900
> >> Connectivity Combo controller (Bluetooth, FM, GPS).
> >>
> >> Signed-off-by: Par-Gunnar Hjalmdahl <par-gunnar.p.hjalmdahl@stericsson.com>
> >> Acked-by: Linus Walleij <linus.walleij@linaro.org>
> >
> > {sigh}
> >
> > This breaks the build again, the error messages are below :(
>
> I suspect the problem is that Per-Gunnar does not know how to reproduce
> your build errors. Are you building for some x86 combination, allyes, etc
> for example? This is likely currently only tested and applicable for ux500
> so a simple "depends on ARCH_U8500" under config CG2900 may solve
> stuff.
All I did was merely enable the driver to be built on my desktop,
something that any developer should have done, right?
And why can't the code be built for any architecture, what is forcing it
for only one platform? That's not the way drivers should be written,
right?
So please fix the real problem, don't just confine it to one
architecture, what is to keep this from showing up on another chip soon?
thanks,
greg k-h
next prev parent reply other threads:[~2011-05-11 1:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-10 15:10 [PATCH v6] staging: Add ST-Ericsson CG2900 driver Par-Gunnar Hjalmdahl
2011-05-10 20:08 ` Greg KH
2011-05-11 0:07 ` Linus Walleij
2011-05-11 1:56 ` Greg KH [this message]
2011-05-11 8:34 ` Par-Gunnar HJALMDAHL
2011-05-11 13:48 ` Greg KH
2011-05-12 11:54 ` Par-Gunnar HJALMDAHL
2011-05-12 16:54 ` Greg KH
2011-05-11 8:37 ` Par-Gunnar HJALMDAHL
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110511015650.GA6840@kroah.com \
--to=greg@kroah.com \
--cc=Lukasz.Rymanowski@tieto.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=arnd@arndb.de \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=lee.jones@linaro.org \
--cc=linus.ml.walleij@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=mathieu.poirier@linaro.org \
--cc=par-gunnar.p.hjalmdahl@stericsson.com \
--cc=pavan_savoy@sify.com \
--cc=pghatwork@gmail.com \
--cc=vitalywool@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).