From: Johan Hedberg <johan.hedberg@gmail.com>
To: Bartosz Szatkowski <bulislaw@linux.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Fix endian conversion for appparams in pbap client
Date: Sun, 15 May 2011 02:30:57 +0300 [thread overview]
Message-ID: <20110514233057.GH28969@dell.ger.corp.intel.com> (raw)
In-Reply-To: <1304877615-10038-1-git-send-email-bulislaw@linux.com>
Hi,
On Sun, May 08, 2011, Bartosz Szatkowski wrote:
> ---
> client/pbap.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/client/pbap.c b/client/pbap.c
> index 837419c..dee85c8 100644
> --- a/client/pbap.c
> +++ b/client/pbap.c
> @@ -312,6 +312,7 @@ static void read_return_apparam(struct session_data *session,
> if (hdr->len == PHONEBOOKSIZE_LEN) {
> guint16 val;
> memcpy(&val, hdr->val, sizeof(val));
> + val = get_be16(&val);
> *phone_book_size = val;
> }
> break;
Two issues with this:
1. Fix your editor settings. You're using spaces instead of tabs for
indentation.
2. Why not do *phone_book_size = get_be16(&val); directly?
Johan
prev parent reply other threads:[~2011-05-14 23:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-08 18:00 [PATCH] Fix endian conversion for appparams in pbap client Bartosz Szatkowski
2011-05-14 23:30 ` Johan Hedberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110514233057.GH28969@dell.ger.corp.intel.com \
--to=johan.hedberg@gmail.com \
--cc=bulislaw@linux.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox