From: "Gustavo F. Padovan" <padovan@profusion.mobi>
To: Andre Guedes <andre.guedes@openbossa.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 02/12] Bluetooth: LE advertising cache
Date: Tue, 17 May 2011 15:43:52 -0300 [thread overview]
Message-ID: <20110517184351.GE3138@joana> (raw)
In-Reply-To: <BANLkTikDg2B0-=TyLAg4AriupRZEsr9OqA@mail.gmail.com>
* Andre Guedes <andre.guedes@openbossa.org> [2011-05-17 15:22:31 -0300]:
> Hi Gustavo,
>
> On Fri, May 13, 2011 at 4:33 PM, Gustavo F. Padovan
> <padovan@profusion.mobi> wrote:
> > Hi Andre,
> >
> > * Andre Guedes <andre.guedes@openbossa.org> [2011-05-06 14:05:11 -0300]:
> >
> >> This patch implements the LE advertising cache. It stores sensitive
> >> information (bdaddr and bdaddr_type so far) gathered from LE
> >> advertising report events.
> >>
> >> Only advertising entries from connectables devices are added to the
> >> cache.
> >>
> >> Signed-off-by: Andre Guedes <andre.guedes@openbossa.org>
> >> ---
> >> include/net/bluetooth/hci_core.h | 13 +++++++
> >> net/bluetooth/hci_core.c | 74 ++++++++++++++++++++++++++++++++++++++
> >> 2 files changed, 87 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/include/net/bluetooth/hci_core.h b/include/net/bluetooth/hci_core.h
> >> index 14cc324..65135f8 100644
> >> --- a/include/net/bluetooth/hci_core.h
> >> +++ b/include/net/bluetooth/hci_core.h
> >> @@ -89,6 +89,12 @@ struct oob_data {
> >> u8 randomizer[16];
> >> };
> >>
> >> +struct adv_entry {
> >> + struct list_head list;
> >> + bdaddr_t bdaddr;
> >> + u8 bdaddr_type;
> >> +};
> >> +
> >> #define NUM_REASSEMBLY 4
> >> struct hci_dev {
> >> struct list_head list;
> >> @@ -181,6 +187,8 @@ struct hci_dev {
> >>
> >> struct list_head remote_oob_data;
> >>
> >> + struct list_head adv_entries;
> >> +
> >> struct hci_dev_stats stat;
> >>
> >> struct sk_buff_head driver_init;
> >> @@ -526,6 +534,11 @@ int hci_add_remote_oob_data(struct hci_dev *hdev, bdaddr_t *bdaddr, u8 *hash,
> >> u8 *randomizer);
> >> int hci_remove_remote_oob_data(struct hci_dev *hdev, bdaddr_t *bdaddr);
> >>
> >> +int hci_adv_entries_clear(struct hci_dev *hdev);
> >> +struct adv_entry *hci_find_adv_entry(struct hci_dev *hdev, bdaddr_t *bdaddr);
> >> +int hci_add_adv_entry(struct hci_dev *hdev,
> >> + struct hci_ev_le_advertising_info *ev);
> >
> > Rename this to hci_adv_add_entry()
> >
>
> 'adv_entry' is the element of the list. So, to follow the standard IMO
> we should keep the name hci_add_adv_entry(). See others functions
> like hci_add_link_key() and hci_add_remote_oob_data().
Fair enough. Keep it hci_add_adv_entry()
--
Gustavo F. Padovan
http://profusion.mobi
next prev parent reply other threads:[~2011-05-17 18:43 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-06 17:05 [PATCH 00/12] Caching LE advertising information Andre Guedes
2011-05-06 17:05 ` [PATCH 01/12] Bluetooth: Add advertising report meta event structs Andre Guedes
2011-05-06 17:05 ` [PATCH 02/12] Bluetooth: LE advertising cache Andre Guedes
2011-05-13 19:33 ` Gustavo F. Padovan
2011-05-17 18:22 ` Andre Guedes
2011-05-17 18:43 ` Gustavo F. Padovan [this message]
2011-05-06 17:05 ` [PATCH 03/12] Bluetooth: Protect 'adv_entries' with a RW lock Andre Guedes
2011-05-12 1:24 ` Marcel Holtmann
2011-05-17 14:39 ` Andre Guedes
2011-05-06 17:05 ` [PATCH 04/12] Bluetooth: Add advertising report meta event handler Andre Guedes
2011-05-06 17:05 ` [PATCH 05/12] Bluetooth: LE Set Scan Enable command complete event Andre Guedes
2011-05-06 17:05 ` [PATCH 06/12] Bluetooth: Clear advertising cache before scanning Andre Guedes
2011-05-06 17:05 ` [PATCH 07/12] Bluetooth: Advertising entries lifetime Andre Guedes
2011-05-06 17:05 ` [PATCH 08/12] Bluetooth: Add 'dst_type' field to struct hci_conn Andre Guedes
2011-05-06 17:05 ` [PATCH 09/12] Bluetooth: Add hci_le_conn_add() Andre Guedes
2011-05-12 1:27 ` Marcel Holtmann
2011-05-06 17:05 ` [PATCH 10/12] Bluetooth: Remove useless check in hci_connect() Andre Guedes
2011-05-06 17:05 ` [PATCH 11/12] Bluetooth: Check advertising cache " Andre Guedes
2011-05-06 17:05 ` [PATCH 12/12] Bluetooth: Set 'peer_addr_type' in hci_le_connect() Andre Guedes
2011-05-12 1:23 ` [PATCH 00/12] Caching LE advertising information Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110517184351.GE3138@joana \
--to=padovan@profusion.mobi \
--cc=andre.guedes@openbossa.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).