From: Johan Hedberg <johan.hedberg@gmail.com>
To: Claudio Takahasi <claudio.takahasi@openbossa.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v5 06/12] Unify inquiry results and advertises
Date: Wed, 18 May 2011 13:53:42 -0700 [thread overview]
Message-ID: <20110518205342.GB31478@dell.amr.corp.intel.com> (raw)
In-Reply-To: <1305747562-19595-1-git-send-email-claudio.takahasi@openbossa.org>
Hi Claudio,
On Wed, May 18, 2011, Claudio Takahasi wrote:
> Adapter needs to have only one method to allow discovery results
> integration for both interfaces: hciops and mgmtops. This patch
> moves the code related to advertises parsing to the same function
> that handles inquiry results.
> ---
> src/adapter.c | 67 ++++++++++++++++++--------------------------------------
> src/adapter.h | 7 +----
> src/event.c | 25 +++-----------------
> 3 files changed, 28 insertions(+), 71 deletions(-)
Patches 3, 4 and 5 have been pushed upstream, but this one causes a
compiler error with gcc 4.6:
src/adapter.c: In function ‘adapter_update_found_devices’:
src/adapter.c:3008:28: error: variable ‘le’ set but not used [-Werror=unused-but-set-variable]
Please fix and resend.
Johan
next prev parent reply other threads:[~2011-05-18 20:53 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-16 20:49 [PATCH v3 01/12] Move EIR related functions to a new file Claudio Takahasi
2011-05-16 20:49 ` [PATCH v3 02/12] Initial device found cleanup Claudio Takahasi
2011-05-16 20:49 ` [PATCH v3 03/12] Move legacy verification to a new function Claudio Takahasi
2011-05-17 16:13 ` Johan Hedberg
2011-05-17 18:25 ` [PATCH v4 " Claudio Takahasi
2011-05-18 19:18 ` Claudio Takahasi
2011-05-18 19:38 ` [PATCH v5 " Claudio Takahasi
2011-05-16 20:49 ` [PATCH v3 04/12] Cleanup read name and alias from storage Claudio Takahasi
2011-05-17 18:25 ` [PATCH v4 " Claudio Takahasi
2011-05-18 19:38 ` [PATCH v5 " Claudio Takahasi
2011-05-16 20:49 ` [PATCH v3 05/12] Don't resolve name if the name is in the storage Claudio Takahasi
2011-05-17 18:25 ` [PATCH v4 " Claudio Takahasi
2011-05-18 19:38 ` [PATCH v5 " Claudio Takahasi
2011-05-16 20:49 ` [PATCH v3 06/12] Unify inquiry results and advertises Claudio Takahasi
2011-05-17 18:25 ` [PATCH v4 " Claudio Takahasi
2011-05-18 19:39 ` [PATCH v5 " Claudio Takahasi
2011-05-18 20:53 ` Johan Hedberg [this message]
2011-05-18 21:33 ` [PATCH v6 " Claudio Takahasi
2011-05-16 20:49 ` [PATCH v3 07/12] Fix memory leak of EIR data Claudio Takahasi
2011-05-17 18:26 ` [PATCH v4 " Claudio Takahasi
2011-05-18 19:39 ` [PATCH v5 " Claudio Takahasi
2011-05-18 21:33 ` [PATCH v6 " Claudio Takahasi
2011-05-16 20:49 ` [PATCH v3 08/12] Remove btd_event_advertising_report Claudio Takahasi
2011-05-17 18:26 ` [PATCH v4 " Claudio Takahasi
2011-05-18 19:39 ` [PATCH v5 " Claudio Takahasi
2011-05-18 21:33 ` [PATCH v6 " Claudio Takahasi
2011-05-16 20:49 ` [PATCH v3 09/12] Change the order to write/read the remote's name Claudio Takahasi
2011-05-17 18:26 ` [PATCH v4 " Claudio Takahasi
2011-05-18 19:39 ` [PATCH v5 " Claudio Takahasi
2011-05-18 21:33 ` [PATCH v6 " Claudio Takahasi
2011-05-16 20:49 ` [PATCH v3 10/12] Cleanup inserting new device found entry Claudio Takahasi
2011-05-17 18:26 ` [PATCH v4 " Claudio Takahasi
2011-05-18 19:39 ` [PATCH v5 " Claudio Takahasi
2011-05-18 21:34 ` [PATCH v6 " Claudio Takahasi
2011-05-16 20:50 ` [PATCH v3 11/12] Replace EIR_DATA_LENGTH with HCI_MAX_EIR_LENGTH Claudio Takahasi
2011-05-17 18:26 ` [PATCH v4 " Claudio Takahasi
2011-05-18 19:40 ` [PATCH v5 " Claudio Takahasi
2011-05-18 21:34 ` [PATCH v6 " Claudio Takahasi
2011-05-16 20:50 ` [PATCH v3 12/12] Drop variable EIR length Claudio Takahasi
2011-05-17 18:26 ` [PATCH v4 " Claudio Takahasi
2011-05-18 19:40 ` [PATCH v5 " Claudio Takahasi
2011-05-18 21:34 ` [PATCH v6 " Claudio Takahasi
2011-05-18 23:49 ` Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110518205342.GB31478@dell.amr.corp.intel.com \
--to=johan.hedberg@gmail.com \
--cc=claudio.takahasi@openbossa.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox