From: Johan Hedberg <johan.hedberg@gmail.com>
To: Dmitriy Paliy <dmitriy.paliy@nokia.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v3 1/2] Fix change to numbers GSlist in new missed calls
Date: Thu, 19 May 2011 16:34:01 -0700 [thread overview]
Message-ID: <20110519233401.GB4016@dell.ger.corp.intel.com> (raw)
In-Reply-To: <1305809864-9963-2-git-send-email-dmitriy.paliy@nokia.com>
Hi Dmitriy,
On Thu, May 19, 2011, Dmitriy Paliy wrote:
> It is possible that phonebook_pull_read is invoked several times
> submitting multiple pull requests without closing PBAP object. E.g.,
> when history is large enough and maxlistcount>VCARDS_PART_COUNT.
>
> The result is possibility of different data structures (GString and
> contact_data) to be mixed in a single GSlist that may lead to
> undefined behaviour.
> ---
> plugins/phonebook-tracker.c | 57 ++++++++++++++++++++++++-------------------
> 1 files changed, 32 insertions(+), 25 deletions(-)
Both patches have been pushed upstream. Could you still explain what
data->numbers is supposed to be useful for? It's not used anywhere in
the code (except where creating and freeing the list).
Johan
next prev parent reply other threads:[~2011-05-19 23:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-19 12:57 [PATCH v3 0/2] Fix change to numbers GSlist in new missed calls Dmitriy Paliy
2011-05-19 12:57 ` [PATCH v3 1/2] " Dmitriy Paliy
2011-05-19 23:34 ` Johan Hedberg [this message]
2011-05-20 6:51 ` Dmitriy Paliy
2011-05-19 12:57 ` [PATCH v3 2/2] Change append to prepend in pull_newmissedcalls Dmitriy Paliy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110519233401.GB4016@dell.ger.corp.intel.com \
--to=johan.hedberg@gmail.com \
--cc=dmitriy.paliy@nokia.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox