From: "Gustavo F. Padovan" <padovan@profusion.mobi>
To: David Miller <davem@davemloft.net>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] bluetooth: Kill set but unused variable 'cmd' in cmtp_recv_capimsg()
Date: Thu, 19 May 2011 23:43:20 -0300 [thread overview]
Message-ID: <20110520024320.GE4888@joana> (raw)
In-Reply-To: <20110519.175005.999414875849956708.davem@davemloft.net>
* David Miller <davem@davemloft.net> [2011-05-19 17:50:05 -0400]:
>
> Signed-off-by: David S. Miller <davem@davemloft.net>
>
> diff --git a/net/bluetooth/cmtp/capi.c b/net/bluetooth/cmtp/capi.c
> index 744233c..040f67b 100644
> --- a/net/bluetooth/cmtp/capi.c
> +++ b/net/bluetooth/cmtp/capi.c
> @@ -326,7 +326,7 @@ void cmtp_recv_capimsg(struct cmtp_session *session, struct sk_buff *skb)
> {
> struct capi_ctr *ctrl = &session->ctrl;
> struct cmtp_application *application;
> - __u16 cmd, appl;
> + __u16 appl;
> __u32 contr;
>
> BT_DBG("session %p skb %p len %d", session, skb, skb->len);
> @@ -344,7 +344,6 @@ void cmtp_recv_capimsg(struct cmtp_session *session, struct sk_buff *skb)
> return;
> }
>
> - cmd = CAPICMD(CAPIMSG_COMMAND(skb->data), CAPIMSG_SUBCOMMAND(skb->data));
> appl = CAPIMSG_APPID(skb->data);
> contr = CAPIMSG_CONTROL(skb->data);
Applied, thanks.
--
Gustavo F. Padovan
http://profusion.mobi
prev parent reply other threads:[~2011-05-20 2:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-19 21:50 [PATCH] bluetooth: Kill set but unused variable 'cmd' in cmtp_recv_capimsg() David Miller
2011-05-20 2:43 ` Gustavo F. Padovan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110520024320.GE4888@joana \
--to=padovan@profusion.mobi \
--cc=davem@davemloft.net \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox