From: "Gustavo F. Padovan" <padovan@profusion.mobi>
To: David Miller <davem@davemloft.net>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] bluetooth: Kill set but not used variable 'l2cap_sk' in rfcomm_sock_getsockopt_old()
Date: Thu, 19 May 2011 23:43:57 -0300 [thread overview]
Message-ID: <20110520024357.GF4888@joana> (raw)
In-Reply-To: <20110519.180900.1412544790459751168.davem@davemloft.net>
* David Miller <davem@davemloft.net> [2011-05-19 18:09:00 -0400]:
>
> Signed-off-by: David S. Miller <davem@davemloft.net>
>
> diff --git a/net/bluetooth/rfcomm/sock.c b/net/bluetooth/rfcomm/sock.c
> index 386cfaf..bcf077c 100644
> --- a/net/bluetooth/rfcomm/sock.c
> +++ b/net/bluetooth/rfcomm/sock.c
> @@ -741,7 +741,6 @@ static int rfcomm_sock_setsockopt(struct socket *sock, int level, int optname, c
> static int rfcomm_sock_getsockopt_old(struct socket *sock, int optname, char __user *optval, int __user *optlen)
> {
> struct sock *sk = sock->sk;
> - struct sock *l2cap_sk;
> struct rfcomm_conninfo cinfo;
> struct l2cap_conn *conn = l2cap_pi(sk)->chan->conn;
> int len, err = 0;
> @@ -786,8 +785,6 @@ static int rfcomm_sock_getsockopt_old(struct socket *sock, int optname, char __u
> break;
> }
>
> - l2cap_sk = rfcomm_pi(sk)->dlc->session->sock->sk;
> -
> cinfo.hci_handle = conn->hcon->handle;
> memcpy(cinfo.dev_class, conn->hcon->dev_class, 3);
applied, thanks.
--
Gustavo F. Padovan
http://profusion.mobi
prev parent reply other threads:[~2011-05-20 2:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-19 22:09 [PATCH] bluetooth: Kill set but not used variable 'l2cap_sk' in rfcomm_sock_getsockopt_old() David Miller
2011-05-20 2:43 ` Gustavo F. Padovan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110520024357.GF4888@joana \
--to=padovan@profusion.mobi \
--cc=davem@davemloft.net \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).