From: Ville Tervo <ville.tervo@nokia.com>
To: ext Andre Guedes <andre.guedes@openbossa.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v2 10/11] Bluetooth: Check advertising cache in hci_connect()
Date: Tue, 24 May 2011 14:15:34 +0300 [thread overview]
Message-ID: <20110524111534.GH2480@null> (raw)
In-Reply-To: <1305936645-15007-10-git-send-email-andre.guedes@openbossa.org>
On Fri, May 20, 2011 at 09:10:44PM -0300, ext Andre Guedes wrote:
> When connecting to a LE device, we need to check the advertising
> cache in order to know the address type of that device.
>
> If its advertising entry is not found, the connection is not
> established and hci_connect() returns error.
>
> Signed-off-by: Andre Guedes <andre.guedes@openbossa.org>
Acked-by: Ville Tervo <ville.tervo@nokia.com>
> ---
> net/bluetooth/hci_conn.c | 9 ++++++++-
> 1 files changed, 8 insertions(+), 1 deletions(-)
>
> diff --git a/net/bluetooth/hci_conn.c b/net/bluetooth/hci_conn.c
> index b21cbb3..468d2aa 100644
> --- a/net/bluetooth/hci_conn.c
> +++ b/net/bluetooth/hci_conn.c
> @@ -451,10 +451,17 @@ struct hci_conn *hci_connect(struct hci_dev *hdev, int type, bdaddr_t *dst, __u8
> BT_DBG("%s dst %s", hdev->name, batostr(dst));
>
> if (type == LE_LINK) {
> + struct adv_entry *entry;
> +
> le = hci_conn_hash_lookup_ba(hdev, LE_LINK, dst);
> if (le)
> return ERR_PTR(-EBUSY);
> - le = hci_conn_add(hdev, LE_LINK, dst, 0);
> +
> + entry = hci_find_adv_entry(hdev, dst);
> + if (!entry)
> + return ERR_PTR(-EHOSTUNREACH);
> +
> + le = hci_conn_add(hdev, LE_LINK, dst, entry->bdaddr_type);
> if (!le)
> return ERR_PTR(-ENOMEM);
>
> --
> 1.7.4.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-05-24 11:15 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-21 0:10 [PATCH v2 01/11] Bluetooth: Add advertising report meta event structs Andre Guedes
2011-05-21 0:10 ` [PATCH v2 02/11] Bluetooth: LE advertising cache Andre Guedes
2011-05-21 0:10 ` [PATCH v2 03/11] Bluetooth: Add Advertising Report Meta Event handler Andre Guedes
2011-05-21 0:10 ` [PATCH v2 04/11] Bluetooth: LE Set Scan Enable command complete event Andre Guedes
2011-05-24 10:42 ` Ville Tervo
2011-05-25 16:42 ` Andre Guedes
2011-05-21 0:10 ` [PATCH v2 05/11] Bluetooth: Clear advertising cache before scanning Andre Guedes
2011-05-24 10:51 ` Ville Tervo
2011-05-21 0:10 ` [PATCH v2 06/11] Bluetooth: Advertising entries lifetime Andre Guedes
2011-06-07 5:18 ` Luiz Augusto von Dentz
2011-06-07 15:02 ` Johan Hedberg
2011-06-07 15:32 ` Anderson Lizardo
2011-06-07 19:08 ` Andre Guedes
2011-06-09 18:20 ` Claudio Takahasi
2011-05-21 0:10 ` [PATCH v2 07/11] Bluetooth: Add 'dst_type' field to struct hci_conn Andre Guedes
2011-05-24 11:08 ` Ville Tervo
2011-05-21 0:10 ` [PATCH v2 08/11] Bluetooth: Add 'dst_type' param to hci_conn_add() Andre Guedes
2011-05-21 0:10 ` [PATCH v2 09/11] Bluetooth: Remove useless check in hci_connect() Andre Guedes
2011-05-24 11:13 ` Ville Tervo
2011-05-21 0:10 ` [PATCH v2 10/11] Bluetooth: Check advertising cache " Andre Guedes
2011-05-24 11:15 ` Ville Tervo [this message]
2011-05-21 0:10 ` [PATCH v2 11/11] Bluetooth: Set 'peer_addr_type' in hci_le_connect() Andre Guedes
2011-05-24 11:16 ` Ville Tervo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110524111534.GH2480@null \
--to=ville.tervo@nokia.com \
--cc=andre.guedes@openbossa.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).