Remove obsolete code in hidd

Remove obsolete code in hidd

[Bastien Nocera]

[-- Attachment #1: Type: text/plain, Size: 65 bytes --]

Heya,

This code has now been in the kernel for a while.

Cheers

[-- Attachment #2: 0001-Remove-obsolete-Sixaxis-enablement-in-hidd.patch --]
[-- Type: text/x-patch, Size: 1166 bytes --]

>From 3a22abd3eb4b8b428bb76069c46d5e8ac2cebb10 Mon Sep 17 00:00:00 2001
From: Bastien Nocera <hadess@hadess.net>
Date: Thu, 5 May 2011 19:41:07 +0100
Subject: [PATCH] Remove obsolete Sixaxis enablement in hidd

Seeing as this is now handled in the kernel.
---
 compat/hidd.c |   12 ------------
 1 files changed, 0 insertions(+), 12 deletions(-)

diff --git a/compat/hidd.c b/compat/hidd.c
index 64dd455..fd1b28c 100644
--- a/compat/hidd.c
+++ b/compat/hidd.c
@@ -237,15 +237,6 @@ static int request_encryption(bdaddr_t *src, bdaddr_t *dst)
 	return err;
 }
 
-static int enable_sixaxis(int csk)
-{
-	const unsigned char buf[] = {
-		0x53 /*HIDP_TRANS_SET_REPORT | HIDP_DATA_RTYPE_FEATURE*/,
-		0xf4,  0x42, 0x03, 0x00, 0x00 };
-
-	return write(csk, buf, sizeof(buf));
-}
-
 static int create_device(int ctl, int csk, int isk, uint8_t subclass, int nosdp, int nocheck, int bootonly, int encrypt, int timeout)
 {
 	struct hidp_connadd_req req;
@@ -334,9 +325,6 @@ create:
 		req.flags |= (1 << HIDP_BOOT_PROTOCOL_MODE);
 	}
 
-	if (req.vendor == 0x054c && req.product == 0x0268)
-		enable_sixaxis(csk);
-
 	err = ioctl(ctl, HIDPCONNADD, &req);
 
 error:
-- 
1.7.5.1

Re: Remove obsolete code in hidd

[Johan Hedberg]

Hi Bastien,

On Thu, May 26, 2011, Bastien Nocera wrote:
> Heya,
> 
> This code has now been in the kernel for a while.
> 
> Cheers

> From 3a22abd3eb4b8b428bb76069c46d5e8ac2cebb10 Mon Sep 17 00:00:00 2001
> From: Bastien Nocera <hadess@hadess.net>
> Date: Thu, 5 May 2011 19:41:07 +0100
> Subject: [PATCH] Remove obsolete Sixaxis enablement in hidd
> 
> Seeing as this is now handled in the kernel.
> ---
>  compat/hidd.c |   12 ------------
>  1 files changed, 0 insertions(+), 12 deletions(-)

Applied, thanks.

In the future, I'd prefer if you could prefix patch email subjects with
[PATCH] (easier for me to spot them) and send the patch inline instead
of as an attachment (so I can use the same steps in mutt for applying
all patches). git send-email would do both of these for you for free.

Johan