linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johan Hedberg <johan.hedberg@gmail.com>
To: "Daniel Örstadius" <daniel.orstadius@gmail.com>
Cc: Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
	linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Init telephony before adding HFP SDP records
Date: Wed, 1 Jun 2011 11:17:29 +0300	[thread overview]
Message-ID: <20110601081729.GA9060@dell.ger.corp.intel.com> (raw)
In-Reply-To: <BANLkTi=1Si-h9AuMRCBKnBjhj6=LXYhuFQ@mail.gmail.com>

Hi Daniel,

On Fri, May 27, 2011, Daniel Örstadius wrote:
> Thanks for the feedback, that seems like a much leaner solution.
> Attaching new patch.
> 
> Regards,
> Daniel

> From 6ef2596d1b42abd6db51d22a5cf2239a0669ca12 Mon Sep 17 00:00:00 2001
> From: Daniel Orstadius <daniel.orstadius@nokia.com>
> Date: Fri, 27 May 2011 11:26:18 +0300
> Subject: [PATCH] Init telephony before adding the HFP SDP record
> 
> By patch b9d85c00108977b24ae91ea8ecedb9ceffe6f648 the initialization
> of the telephony subsystem is delayed in the bluetoothd startup
> procedure. As a result the SupportedFeatures bitmap has not been set
> when creating the HFP SDP record. This patch changes the order of
> the telephony initialization (via the state_changed function) and
> the registration of the record, so that it gets the right value.
> 
> Although the corresponding bit in +BRSF is correctly set, the
> missing bit for the "Three-way calling" feature in the SDP record
> causes some headsets not to send AT+CHLD=? in certain situations.
> This results in failed connections since BlueZ does not enter the
> "connected" state on the headset interface before that command is
> received, if the feature is supported by both sides.
> ---
>  audio/manager.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)

Applied. Thanks.

Johan

      parent reply	other threads:[~2011-06-01  8:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-26 13:58 [PATCH] Init telephony before adding HFP SDP records Daniel Örstadius
2011-05-26 15:44 ` Luiz Augusto von Dentz
2011-05-27  8:40   ` Daniel Örstadius
2011-05-27 10:26     ` Luiz Augusto von Dentz
2011-05-27 10:45       ` Daniel Örstadius
2011-06-01  7:58         ` Daniel Örstadius
2011-06-01  8:17           ` Luiz Augusto von Dentz
2011-06-01  8:17     ` Johan Hedberg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110601081729.GA9060@dell.ger.corp.intel.com \
    --to=johan.hedberg@gmail.com \
    --cc=daniel.orstadius@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=luiz.dentz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).