From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 1 Jun 2011 11:17:29 +0300 From: Johan Hedberg To: Daniel =?iso-8859-1?Q?=D6rstadius?= Cc: Luiz Augusto von Dentz , linux-bluetooth@vger.kernel.org Subject: Re: [PATCH] Init telephony before adding HFP SDP records Message-ID: <20110601081729.GA9060@dell.ger.corp.intel.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 In-Reply-To: Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Hi Daniel, On Fri, May 27, 2011, Daniel Örstadius wrote: > Thanks for the feedback, that seems like a much leaner solution. > Attaching new patch. > > Regards, > Daniel > From 6ef2596d1b42abd6db51d22a5cf2239a0669ca12 Mon Sep 17 00:00:00 2001 > From: Daniel Orstadius > Date: Fri, 27 May 2011 11:26:18 +0300 > Subject: [PATCH] Init telephony before adding the HFP SDP record > > By patch b9d85c00108977b24ae91ea8ecedb9ceffe6f648 the initialization > of the telephony subsystem is delayed in the bluetoothd startup > procedure. As a result the SupportedFeatures bitmap has not been set > when creating the HFP SDP record. This patch changes the order of > the telephony initialization (via the state_changed function) and > the registration of the record, so that it gets the right value. > > Although the corresponding bit in +BRSF is correctly set, the > missing bit for the "Three-way calling" feature in the SDP record > causes some headsets not to send AT+CHLD=? in certain situations. > This results in failed connections since BlueZ does not enter the > "connected" state on the headset interface before that command is > received, if the feature is supported by both sides. > --- > audio/manager.c | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) Applied. Thanks. Johan