Re: [PATCH] Corrected udev rule for Logitech devices

[Johan Hedberg <johan.hedberg@gmail.com>]

Hi Peter,

On Fri, Jun 03, 2011, Peter Hurley wrote:
> The *real* history of this file is a nightmare. Now that it's
> back in the bluez project, fix the problems that were added
> while it was in udev.
> 
> 1) Only hiddev* devices provide the ioctl interface hid2hci uses
> to switch from HID->HCI for --method=logitech-hid.  (inquiring
> minds can look in the kernel git tree at drivers/hid/usbhid/hiddev.c)
> 2) hidraw* devices don't belong to subsystem=usb (they are
> subsystem=hidraw).  This means that the udev rule that matched based on
> hidraw* would never have been run anyway because of the early-out
> subsystem!=usb on line 4.
> 
> This fix is going to cause major regressions in distros because there
> is currently no way provided by bluez to *NOT* run hid2hci.
> 
> Many, many users (and maintainers) mistakenly believe that because
> the keyboard and mouse works when the vid/pid of their device is matched
> by the hidraw* rule, that "bluetooth" must be working. Of course, what's
> really happening is the keyboard and mouse are working as HID input
> devices instead.
> 
> Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
> ---
>  scripts/bluetooth-hid2hci.rules |    4 +---
>  1 files changed, 1 insertions(+), 3 deletions(-)

Applied (without the signed-off-by line since we don't use that).
Thanks!

Johan