From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 9 Jun 2011 16:09:43 -0300 From: "Gustavo F. Padovan" To: Elvis Pfutzenreuter Cc: Johan Hedberg , Santiago Carot , Claudio Takahasi , BlueZ development Subject: Re: Read clock not implemented in management Message-ID: <20110609190943.GC2533@joana> References: <20110609122805.GA8875@dell.ccr.corp.intel.com> <82461851-7132-415D-A9D1-AE5C1B64440E@signove.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <82461851-7132-415D-A9D1-AE5C1B64440E@signove.com> Sender: linux-bluetooth-owner@vger.kernel.org List-ID: * Elvis Pfutzenreuter [2011-06-09 09:42:42 -0300]: > On Jun 9, 2011, at 9:28 AM, Johan Hedberg wrote: > > > Hi, > > > > On Thu, Jun 09, 2011, Elvis Pfutzenreuter wrote: > >>> Coming back to this issue. I'm not caught up with this stuff and I > >>> dont know if there are any special reason to not provide a read clock > >>> functionality in the bluetooth API. although I think it's a pity to > >>> restrict MCAP features after the good work Elvis did in CSP. > >> > >> More to the point, could we implement HCI read clock for mgmt interface? Or > >> it simply won't have read clock by design? > > > > There's no obvious reason why it couldn't have it. However other means > > should be considered too, e.g. would it be cleaner to get the info > > directly through the socket (using a socket option or something > > similar)? Or was this already considered when the HCI socket solution > > was implemented? > > Not exactly, I just made use of hci_read_clock() that already existed in BlueZ > API, and copied the code into hciops. > > Getting clock via a socket option sounds better to me since a) we need > connection ACL to read it, getting it through a L2CAP socket would imply the > ACL; b) it would allow other apps to use the feature (e.g. PyBluez that > currently reads clock using an HCI socket). Getting it from a L2CAP socket does not seems right. If you want to read a clock value, probably the ACL link is already there. Implement this on the management interface is the best option. Gustavo