* [PATCH] Fix AVCTP reply for message with invalid PID
@ 2011-06-09 13:55 Szymon Janc
2011-06-14 8:14 ` Johan Hedberg
0 siblings, 1 reply; 2+ messages in thread
From: Szymon Janc @ 2011-06-09 13:55 UTC (permalink / raw)
To: linux-bluetooth; +Cc: par-gunnar.p.hjalmdahl, ulrik.lauren, Szymon Janc
Reply for control message with invalid (not registered for reception
of messages) PID should not have message information field present.
This was affecting AVCTP 1.3 qualification test case TP/NFR/BI-01-C.
---
audio/control.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/audio/control.c b/audio/control.c
index 9ede0f2..3db7d8e 100644
--- a/audio/control.c
+++ b/audio/control.c
@@ -566,7 +566,7 @@ static gboolean control_cb(GIOChannel *chan, GIOCondition cond,
} else if (avctp->pid != htons(AV_REMOTE_SVCLASS_ID)) {
avctp->ipid = 1;
avctp->cr = AVCTP_RESPONSE;
- avrcp->code = CTYPE_REJECTED;
+ packet_size = sizeof(*avctp);
} else if (avctp->cr == AVCTP_COMMAND &&
avrcp->code == CTYPE_CONTROL &&
avrcp->subunit_type == SUBUNIT_PANEL &&
--
on behalf of ST-Ericsson
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Fix AVCTP reply for message with invalid PID
2011-06-09 13:55 [PATCH] Fix AVCTP reply for message with invalid PID Szymon Janc
@ 2011-06-14 8:14 ` Johan Hedberg
0 siblings, 0 replies; 2+ messages in thread
From: Johan Hedberg @ 2011-06-14 8:14 UTC (permalink / raw)
To: Szymon Janc; +Cc: linux-bluetooth, par-gunnar.p.hjalmdahl, ulrik.lauren
Hi Szymon,
On Thu, Jun 09, 2011, Szymon Janc wrote:
> Reply for control message with invalid (not registered for reception
> of messages) PID should not have message information field present.
>
> This was affecting AVCTP 1.3 qualification test case TP/NFR/BI-01-C.
> ---
> audio/control.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Applied. Thanks.
Johan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-06-14 8:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-09 13:55 [PATCH] Fix AVCTP reply for message with invalid PID Szymon Janc
2011-06-14 8:14 ` Johan Hedberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).