From: Johan Hedberg <johan.hedberg@gmail.com>
To: Bastien Nocera <hadess@hadess.net>
Cc: Anderson Lizardo <anderson.lizardo@openbossa.org>,
linux-bluetooth@vger.kernel.org, luiz.dentz@gmail.com
Subject: Re: [PATCH] adaptername: Move adapter naming into a plugin
Date: Tue, 14 Jun 2011 12:43:38 +0300 [thread overview]
Message-ID: <20110614094338.GA18317@dell.ger.corp.intel.com> (raw)
In-Reply-To: <1308043116.26522.1.camel@air.hadess.net>
Hi Bastien,
On Tue, Jun 14, 2011, Bastien Nocera wrote:
> On Tue, 2011-06-14 at 11:07 +0300, Johan Hedberg wrote:
> > Hi Bastien,
> <snip>
> > This could simply be:
> >
> > if (adapter->up)
> > return adapter_ops->set_name(adapter->dev_id, name);
> >
> > return 0;
> >
> > Other than that I didn't find any major issues, however please consider
> > the suggestion from Lizardo to split the patch in two parts.
>
> I already sent the split patches (2 of them) last week:
> http://thread.gmane.org/gmane.linux.bluez.kernel/13621
No, I did notice that thread. It's not a split of this patch. For one
thing it doesn't contain any adaptername plugin at all.
What about the coding style issues I pointed out?
I also need to look more carefully into the name_stored change. I'm not
sure you completely understood its significance. This is also a change
which doesn't exist in your original patch (again confirming that the
new thread is *not* a split of the original patch).
Johan
next prev parent reply other threads:[~2011-06-14 9:43 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-26 14:11 Another pass at adapter naming Bastien Nocera
2011-05-26 14:50 ` Bastien Nocera
2011-05-26 16:00 ` Luiz Augusto von Dentz
2011-05-26 16:12 ` Bastien Nocera
2011-05-26 16:46 ` Luiz Augusto von Dentz
2011-05-26 16:56 ` Bastien Nocera
2011-05-30 12:05 ` Luiz Augusto von Dentz
2011-05-30 14:50 ` Bastien Nocera
2011-06-07 9:34 ` [PATCH] adaptername: Move adapter naming into a plugin Bastien Nocera
2011-06-07 9:49 ` Daniele Forsi
2011-06-07 10:03 ` Bastien Nocera
2011-06-08 16:13 ` Anderson Lizardo
2011-06-08 17:38 ` Bastien Nocera
2011-06-14 8:07 ` Johan Hedberg
2011-06-14 9:18 ` Bastien Nocera
2011-06-14 9:43 ` Johan Hedberg [this message]
2011-06-15 10:18 ` Bastien Nocera
2011-06-15 13:00 ` Anderson Lizardo
2011-06-15 21:04 ` Johan Hedberg
2011-07-19 11:26 ` Luiz Augusto von Dentz
2011-07-19 11:35 ` Luiz Augusto von Dentz
2011-07-19 12:35 ` Bastien Nocera
2011-06-08 17:43 ` Bastien Nocera
2011-06-08 19:30 ` Anderson Lizardo
2011-06-07 10:03 ` Bastien Nocera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110614094338.GA18317@dell.ger.corp.intel.com \
--to=johan.hedberg@gmail.com \
--cc=anderson.lizardo@openbossa.org \
--cc=hadess@hadess.net \
--cc=linux-bluetooth@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).