From: Johan Hedberg <johan.hedberg@gmail.com>
To: Andre Guedes <andre.guedes@openbossa.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 1/3] Bluetooth: Add extfeatures to struct hci_dev
Date: Wed, 22 Jun 2011 00:27:31 +0300 [thread overview]
Message-ID: <20110621205505.GA8124@dell.ger.corp.intel.com> (raw)
In-Reply-To: <1308686870-26101-1-git-send-email-andre.guedes@openbossa.org>
Hi André,
On Tue, Jun 21, 2011, Andre Guedes wrote:
> @@ -224,6 +225,11 @@ static void hci_init_req(struct hci_dev *hdev, unsigned long opt)
> /* Read Local Supported Features */
> hci_send_cmd(hdev, HCI_OP_READ_LOCAL_FEATURES, 0, NULL);
>
> + /* Read Local Extended Features */
> + ext_cp.page = 0x01;
> + hci_send_cmd(hdev, HCI_OP_READ_LOCAL_EXT_FEATURES, sizeof(ext_cp),
> + &ext_cp);
Since the extended features command is only available from 1.2 onwards I
don't think it's right to unconditionally send it in hci_init_req.
Instead, you should probably be checking for the feature bit in the
(non-extended) feature mask, i.e. in the command complete callback for
HCI_Read_Local_Features and only send the command if the feature bit is
set.
Johan
next prev parent reply other threads:[~2011-06-21 21:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-21 20:07 [PATCH 1/3] Bluetooth: Add extfeatures to struct hci_dev Andre Guedes
2011-06-21 20:07 ` [PATCH 2/3] Bluetooth: Write LE Host Supported command complete event Andre Guedes
2011-06-21 20:07 ` [PATCH 3/3] Bluetooth: Add MGMT_OP_SET_LE_SUPPORT command Andre Guedes
2011-06-21 20:36 ` Marcel Holtmann
2011-06-22 16:36 ` Andre Guedes
2011-06-22 16:57 ` Marcel Holtmann
2011-06-22 18:33 ` Andre Guedes
2011-06-22 19:20 ` Gustavo F. Padovan
2011-06-22 20:00 ` Andre Guedes
2011-06-23 3:40 ` Marcel Holtmann
2011-06-21 21:27 ` Johan Hedberg [this message]
2011-06-22 2:16 ` [PATCH 1/3] Bluetooth: Add extfeatures to struct hci_dev Marcel Holtmann
2011-06-22 16:40 ` Andre Guedes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110621205505.GA8124@dell.ger.corp.intel.com \
--to=johan.hedberg@gmail.com \
--cc=andre.guedes@openbossa.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).