Re: [PATCH] Add adaptername plugin

[Johan Hedberg <johan.hedberg@gmail.com>]

Hi Bastien,

On Tue, Jun 28, 2011, Bastien Nocera wrote:
> Replacing the name setting code in src/adapter.c.
> 
> Moving the adapter naming allows us to use the /etc/machine-info [1]
> pretty hostname, as implemented by hostnamed [2] in systemd.
> 
> If /etc/machine-info is not present, the adapter name stored
> on disk in /var/lib/bluetooth will be used. If no adapter name
> has been set yet, the default from the main.conf will be used.
> 
> We don't currently number the name of hci0 if a pretty name is
> available, but we should instead number it if it happens not
> to be the default adapter. As we cannot be told when the default
> adapter changes, we'll behave this way for now.
> 
> Note that when an adapter name is set automatically from
> the pretty hostname, changing it through the D-Bus interface
> will fail.
> 
> [1]: http://0pointer.de/public/systemd-man/machine-info.html
> [2]: http://www.freedesktop.org/wiki/Software/systemd/hostnamed
> ---
>  Makefile.am           |    3 +
>  configure.ac          |    4 +
>  plugins/adaptername.c |  321 +++++++++++++++++++++++++++++++++++++++++++++++++
>  src/adapter.c         |   66 ----------
>  4 files changed, 328 insertions(+), 66 deletions(-)
>  create mode 100644 plugins/adaptername.c

Thanks for the quick response. After a couple of more (minor) coding
style fixes the patch is now upstream.

Johan