* [PATCH] Fixed wrong AVCTP response to unregistered PID
@ 2011-06-28 11:28 chen.ganir
2011-06-28 13:37 ` Johan Hedberg
0 siblings, 1 reply; 2+ messages in thread
From: chen.ganir @ 2011-06-28 11:28 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Chen Ganir
From: Chen Ganir <chen.ganir@ti.com>
AVCTP response to unregistered PID should consist only
from the first 3 octets of the AVCTP header, without
any additional frame data (Fix for PTS certification
issue)
---
audio/control.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/audio/control.c b/audio/control.c
index ceb3d88..7c92d10 100755
--- a/audio/control.c
+++ b/audio/control.c
@@ -580,9 +580,10 @@ static gboolean control_cb(GIOChannel *chan, GIOCondition cond,
avctp->cr = AVCTP_RESPONSE;
avrcp->code = CTYPE_NOT_IMPLEMENTED;
} else if (avctp->pid != htons(AV_REMOTE_SVCLASS_ID)) {
+ DBG("AVCTP invalid pid (%d) specified. Rejecting request",avctp->pid);
avctp->ipid = 1;
avctp->cr = AVCTP_RESPONSE;
- avrcp->code = CTYPE_REJECTED;
+ packet_size = sizeof(struct avctp_header);
} else if (avctp->cr == AVCTP_COMMAND &&
avrcp->code == CTYPE_CONTROL &&
avrcp->subunit_type == SUBUNIT_PANEL &&
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Fixed wrong AVCTP response to unregistered PID
2011-06-28 11:28 [PATCH] Fixed wrong AVCTP response to unregistered PID chen.ganir
@ 2011-06-28 13:37 ` Johan Hedberg
0 siblings, 0 replies; 2+ messages in thread
From: Johan Hedberg @ 2011-06-28 13:37 UTC (permalink / raw)
To: chen.ganir; +Cc: linux-bluetooth, Chen Ganir
Hi Chen,
On Tue, Jun 28, 2011, chen.ganir@gmail.com wrote:
> AVCTP response to unregistered PID should consist only from the first
> 3 octets of the AVCTP header, without any additional frame data (Fix
> for PTS certification issue)
> ---
> audio/control.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
This doesn't apply to upstream git, and in fact upstream already has a
fix for this.
Johan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-06-28 13:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-28 11:28 [PATCH] Fixed wrong AVCTP response to unregistered PID chen.ganir
2011-06-28 13:37 ` Johan Hedberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).