From: Gustavo Padovan <padovan@profusion.mobi>
To: Emeltchenko Andrei <Andrei.Emeltchenko.news@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: L2CAP extended feature mask update
Date: Tue, 5 Jul 2011 13:00:28 -0300 [thread overview]
Message-ID: <20110705160028.GB29925@joana> (raw)
In-Reply-To: <1309869322-26307-1-git-send-email-Andrei.Emeltchenko.news@gmail.com>
Hi Andrei,
* Emeltchenko Andrei <Andrei.Emeltchenko.news@gmail.com> [2011-07-05 15:35:22 +0300]:
> From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
>
> Update L2CAP extended feature mask to reflect recent BT spec.
>
> Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
> ---
> include/net/bluetooth/l2cap.h | 6 +++++-
> 1 files changed, 5 insertions(+), 1 deletions(-)
>
> diff --git a/include/net/bluetooth/l2cap.h b/include/net/bluetooth/l2cap.h
> index 9c18e55..d85e55c 100644
> --- a/include/net/bluetooth/l2cap.h
> +++ b/include/net/bluetooth/l2cap.h
> @@ -92,13 +92,17 @@ struct l2cap_conninfo {
> #define L2CAP_CONN_PARAM_UPDATE_REQ 0x12
> #define L2CAP_CONN_PARAM_UPDATE_RSP 0x13
>
> -/* L2CAP feature mask */
> +/* L2CAP extended feature mask */
> #define L2CAP_FEAT_FLOWCTL 0x00000001
> #define L2CAP_FEAT_RETRANS 0x00000002
> +#define L2CAP_FEAT_BIDIR_QOS 0x00000004
> #define L2CAP_FEAT_ERTM 0x00000008
> #define L2CAP_FEAT_STREAMING 0x00000010
> #define L2CAP_FEAT_FCS 0x00000020
> +#define L2CAP_FEAT_EXT_FLOW 0x00000040
> #define L2CAP_FEAT_FIXED_CHAN 0x00000080
> +#define L2CAP_FEAT_EXT_WINDOW 0x00000100
> +#define L2CAP_FEAT_UCD 0x00000200
I don't see the point in adding if we are not using them. Let's add them when
we have code that uses such macros.
Gustavo
next prev parent reply other threads:[~2011-07-05 16:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-05 12:35 [PATCH] Bluetooth: L2CAP extended feature mask update Emeltchenko Andrei
2011-07-05 16:00 ` Gustavo Padovan [this message]
2011-07-06 7:17 ` Andrei Emeltchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110705160028.GB29925@joana \
--to=padovan@profusion.mobi \
--cc=Andrei.Emeltchenko.news@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox