From: Johan Hedberg <johan.hedberg@gmail.com>
To: Dmitriy Paliy <dmitriy.paliy@gmail.com>
Cc: linux-bluetooth@vger.kernel.org, Dmitriy Paliy <dmitriy.paliy@nokia.com>
Subject: Re: [PATCH obexd v3] Fix finalize request in callback function
Date: Mon, 11 Jul 2011 01:17:50 +0300 [thread overview]
Message-ID: <20110710221750.GA16162@dell.ger.corp.intel.com> (raw)
In-Reply-To: <1310331675-10665-2-git-send-email-dmitriy.paliy@nokia.com>
Hi Dmitriy,
On Mon, Jul 11, 2011, Dmitriy Paliy wrote:
> Request shell be finalized in cache_ready_notify callback function.
> Otherwise, reference to the request is kept until vobject is closed.
> It is correct in current implementation since there are no nested
> backend requests when pulling vcard listing.
>
> However, this contradicts to current design (see phonebook_size_result,
> query_result, cache_entry_done) and may cause problems if such
> implementation would be needed.
> ---
> plugins/pbap.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
Applied after I fixed your author info (it was @gmail.com) and minor
spelling issue (shell/shall) in the commit message. Thanks.
Johan
prev parent reply other threads:[~2011-07-10 22:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-10 21:01 [PATCH obexd v3] Fix finalize request in callback function Dmitriy Paliy
2011-07-10 21:01 ` Dmitriy Paliy
2011-07-10 22:17 ` Johan Hedberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110710221750.GA16162@dell.ger.corp.intel.com \
--to=johan.hedberg@gmail.com \
--cc=dmitriy.paliy@gmail.com \
--cc=dmitriy.paliy@nokia.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).