[PATCH obexd v3] Fix finalize request in callback function

[PATCH obexd v3] Fix finalize request in callback function

[Dmitriy Paliy]

This is rebased version, no structural changes.

Br,
Dmitriy

[PATCH obexd v3] Fix finalize request in callback function

[Dmitriy Paliy]

Request shell be finalized in cache_ready_notify callback function.
Otherwise, reference to the request is kept until vobject is closed.
It is correct in current implementation since there are no nested
backend requests when pulling vcard listing.

However, this contradicts to current design (see phonebook_size_result,
query_result, cache_entry_done) and may cause problems if such
implementation would be needed.
---
 plugins/pbap.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/plugins/pbap.c b/plugins/pbap.c
index 7eedfe0..e14a58d 100644
--- a/plugins/pbap.c
+++ b/plugins/pbap.c
@@ -487,6 +487,9 @@ static void cache_ready_notify(void *user_data)
 
 	DBG("");
 
+	phonebook_req_finalize(pbap->obj->request);
+	pbap->obj->request = NULL;
+
 	pbap->cache.valid = TRUE;
 
 	generate_response(pbap);
-- 
1.7.4.1

Re: [PATCH obexd v3] Fix finalize request in callback function

[Johan Hedberg]

Hi Dmitriy,

On Mon, Jul 11, 2011, Dmitriy Paliy wrote:
> Request shell be finalized in cache_ready_notify callback function.
> Otherwise, reference to the request is kept until vobject is closed.
> It is correct in current implementation since there are no nested
> backend requests when pulling vcard listing.
> 
> However, this contradicts to current design (see phonebook_size_result,
> query_result, cache_entry_done) and may cause problems if such
> implementation would be needed.
> ---
>  plugins/pbap.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)

Applied after I fixed your author info (it was @gmail.com) and minor
spelling issue (shell/shall) in the commit message. Thanks.

Johan