From: Johan Hedberg <johan.hedberg@gmail.com>
To: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH obexd 1/6 v2] Make use of g_slist_free_full when elements are dynamically-allocated
Date: Mon, 18 Jul 2011 23:56:14 +0300 [thread overview]
Message-ID: <20110718205614.GA16958@dell.ger.corp.intel.com> (raw)
In-Reply-To: <1310995152-24121-1-git-send-email-luiz.dentz@gmail.com>
Hi Luiz,
On Mon, Jul 18, 2011, Luiz Augusto von Dentz wrote:
> This avoid having to iterate twice in the list to free its elements.
> ---
> configure.ac | 3 +++
> plugins/bluetooth.c | 8 +++-----
> plugins/pbap.c | 7 ++++---
> plugins/phonebook-dummy.c | 3 +--
> plugins/phonebook-tracker.c | 5 ++---
> plugins/vcard.c | 18 ++++++------------
> src/obex.h | 8 ++++++++
> 7 files changed, 27 insertions(+), 25 deletions(-)
Doesn't compile:
CC plugins/vcard.o
In file included from plugins/vcard.c:33:0:
./src/obex.h:66:51: error: unknown type name ‘obex_object_t’
./src/obex.h:68:48: error: unknown type name ‘obex_object_t’
make[1]: *** [plugins/vcard.o] Error 1
Please fix and resend.
Johan
next prev parent reply other threads:[~2011-07-18 20:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-18 13:19 [PATCH obexd 1/6 v2] Make use of g_slist_free_full when elements are dynamically-allocated Luiz Augusto von Dentz
2011-07-18 20:56 ` Johan Hedberg [this message]
2011-07-19 9:04 ` Luiz Augusto von Dentz
2011-07-27 11:22 ` Luiz Augusto von Dentz
2011-07-28 5:57 ` Slawomir Bochenski
2011-07-28 6:46 ` Luiz Augusto von Dentz
2011-07-28 6:54 ` Slawomir Bochenski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110718205614.GA16958@dell.ger.corp.intel.com \
--to=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox