From: Gustavo Padovan <padovan@profusion.mobi>
To: Peter Hurley <peter@hurleysoftware.com>
Cc: linux-bluetooth <linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH] Bluetooth: Allow ACL packets over USB in HCI_RAW mode
Date: Thu, 21 Jul 2011 12:09:45 -0300 [thread overview]
Message-ID: <20110721150945.GA3387@joana> (raw)
In-Reply-To: <1310647712.3208.3.camel@THOR>
Hi Peter,
* Peter Hurley <peter@hurleysoftware.com> [2011-07-14 08:48:32 -0400]:
> Removed tests which prevent transmission of ACL packets
> when the device is in HCI_RAW mode. These tests verified that
> there are ACL or LE links currently tracked by the HCI
> connection manager. However, a HCI_RAW mode device does not
> use the connection manager. In these circumstances, the connection
> counts will be zero, and thus, transmitted ACL packets dropped.
>
> The acl_num test is actually a vestige of a previous bulk URB
> scheme that is no longer used by this driver (bulk URBs were not
> started until at least one ACL connection was created). This was
> incompatible with some endpoint implementations and was dropped -
> see commit 43c2e57f94.
>
> The utility of these tests is marginal - currently, the hci tx
> scheduler cannot send an ACL or LE packet for an untracked connection
> (except if the device is in HCI_RAW mode).
>
> Lastly, no other transport layer driver enforces these same tests.
> ---
> drivers/bluetooth/btusb.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
Applied, thanks.
Gustavo
prev parent reply other threads:[~2011-07-21 15:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-14 12:48 [PATCH] Bluetooth: Allow ACL packets over USB in HCI_RAW mode Peter Hurley
2011-07-17 11:02 ` Marcel Holtmann
2011-07-21 15:09 ` Gustavo Padovan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110721150945.GA3387@joana \
--to=padovan@profusion.mobi \
--cc=linux-bluetooth@vger.kernel.org \
--cc=peter@hurleysoftware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).