Re: [PATCH] Fix debug messages logging from non-built-in plugins

[Szymon Janc <szymon.janc@tieto.com>]

Hi Marcel,

> >  audio/main.c           |    2 +-
> >  health/hdp_main.c      |    1 +
> >  input/main.c           |    2 +-
> >  network/main.c         |    1 +
> >  plugins/adaptername.c  |    2 +-
> >  plugins/formfactor.c   |    2 +-
> >  plugins/gatt-example.c |    2 +-
> >  plugins/hciops.c       |    2 +-
> >  plugins/mgmtops.c      |    2 +-
> >  plugins/service.c      |    2 +-
> >  plugins/storage.c      |    2 +-
> >  sap/main.c             |    1 +
> >  serial/main.c          |    1 +
> >  src/log.c              |   25 +++++++++++++++++++++++++
> >  src/log.h              |    8 ++++++++
> >  src/plugin.c           |   10 +++++++---
> >  src/plugin.h           |    8 ++++++--
> >  17 files changed, 59 insertions(+), 14 deletions(-)
> 
> before you do such a massive change, please explain what you are trying
> to do. This change effects multiple projects (obexd, ConnMan, oFono
> etc.) that are essentially using the same infrastructure.

Currently we are not able to see any debug messages from external plugins.
This regression was introduced with dynamic debug support and mostly (probably)
hits android platform which does build some plugins as external so files.

I can declare 'struct btd_debug_section' in plugin.h instead if you prefer.
That way log.h will not have to be included before plugin.h and will make this
patch smaller, yet having it declared in log.h seems better for me.. 

-- 
BR
Szymon Janc