Linux bluetooth development
 help / color / mirror / Atom feed
From: Johan Hedberg <johan.hedberg@gmail.com>
To: Bartosz Szatkowski <bulislaw@linux.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH obexd 2/2 v2] Add SetFolder function for MAP tracker backend
Date: Tue, 26 Jul 2011 12:24:18 +0300	[thread overview]
Message-ID: <20110726092418.GA28891@dell> (raw)
In-Reply-To: <1310732986-7695-1-git-send-email-bulislaw@linux.com>

Hi Bartosz,

On Fri, Jul 15, 2011, Bartosz Szatkowski wrote:
> ---
>  plugins/messages-tracker.c |  170 +++++++++++++++++++++++++++++++++++++++++++-
>  1 files changed, 168 insertions(+), 2 deletions(-)

This doesn't compile:

plugins/messages.c: In function ‘messages_set_folder’:
plugins/messages.c:82:2: error: ‘last’ may be used uninitialized in this function [-Werror=uninitialized]
plugins/messages.c:50:10: note: ‘last’ was declared here

Additionally, please use match_found and not match_find as a variable
name.

Johan

  reply	other threads:[~2011-07-26  9:24 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-14 13:46 [PATCH obexd 1/2] Add tracker backend stump for MAP Bartosz Szatkowski
2011-07-14 13:46 ` [PATCH obexd 2/2] Add SetFolder function for MAP tracker backend Bartosz Szatkowski
2011-07-14 14:08   ` Johan Hedberg
2011-07-15 12:29     ` [PATCH obexd 2/2 v2] " Bartosz Szatkowski
2011-07-26  9:24       ` Johan Hedberg [this message]
2011-07-26  9:40         ` [PATCH] " Bartosz Szatkowski
2011-07-26 10:32           ` Johan Hedberg
2011-07-14 13:59 ` [PATCH obexd 1/2] Add tracker backend stump for MAP Johan Hedberg
2011-07-14 14:07   ` [PATCH obexd 1/2 v2] " Bartosz Szatkowski
2011-07-14 14:14     ` Johan Hedberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110726092418.GA28891@dell \
    --to=johan.hedberg@gmail.com \
    --cc=bulislaw@linux.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox