From: Johan Hedberg <johan.hedberg@intel.com>
To: Rafal Michalski <michalski.raf@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH obexd 1/6] Support for semicolon escaping
Date: Tue, 26 Jul 2011 13:13:29 +0300 [thread overview]
Message-ID: <20110726101329.GF28891@dell> (raw)
In-Reply-To: <1311145907-3874-1-git-send-email-michalski.raf@gmail.com>
Hi Rafal,
On Wed, Jul 20, 2011, Rafal Michalski wrote:
> According to specification of vcard 2.1, semicolon is only character
> which is escaped with a backslash character (in vcard's property field
> content). This patch provides "escape_semicolon" function which handles
> this issue.
> ---
> plugins/vcard.c | 14 ++++++++++++++
> 1 files changed, 14 insertions(+), 0 deletions(-)
Doesn't compile:
plugins/vcard.c:152:13: error: ‘escape_semicolon’ defined but not used [-Werror=unused-function]
If you're going to add a static function you also need to have at least
one user of it in the same patch.
Johan
prev parent reply other threads:[~2011-07-26 10:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-20 7:11 [PATCH obexd 1/6] Support for semicolon escaping Rafal Michalski
2011-07-20 7:11 ` [PATCH obexd 2/6] Add escaping selection method Rafal Michalski
2011-07-20 7:11 ` [PATCH obexd 3/6] Support for "quoted printable" encoding Rafal Michalski
2011-07-20 7:11 ` [PATCH obexd 4/6] Add encoding selection method Rafal Michalski
2011-07-20 7:11 ` [PATCH obexd 5/6] Fix phone number printing Rafal Michalski
2011-07-20 7:11 ` [PATCH obexd 6/6] Adjust escaping and encoding in vcard module Rafal Michalski
2011-07-26 10:13 ` Johan Hedberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110726101329.GF28891@dell \
--to=johan.hedberg@intel.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=michalski.raf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).