From: Szymon Janc <szymon@janc.net.pl>
To: Peter Hurley <peter@hurleysoftware.com>
Cc: "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH] Bluetooth: Increase command tx timeout
Date: Tue, 26 Jul 2011 21:52:23 +0200 [thread overview]
Message-ID: <201107262152.23761.szymon@janc.net.pl> (raw)
In-Reply-To: <1311264883.17476.65.camel@THOR>
Hi Peter,
> Respectfully, I disagree that this is the correct fix for this problem.
>
> After an HCI_Reset, *no* hci commands should be issued until after the
> *successful* Command Complete is received. IMHO, the current code
> suffers two defects:
> - it doesn't wait for Command Complete after the Reset command is sent
> - it ignores the result code from that Command Complete
>
> I believe the proper fix is to _loop_ over the HCI_Reset until a
> successful Command Complete is received.
Yes, You've got a point.. I've already prepared and tested a proper fix and
will send it shortly.
Thanks for advice!
--
Szymon K. Janc
szymon@janc.net.pl // GG: 1383435
prev parent reply other threads:[~2011-07-26 19:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-20 19:12 [PATCH] Bluetooth: Increase command tx timeout Szymon Janc
2011-07-21 16:14 ` Peter Hurley
2011-07-26 19:52 ` Szymon Janc [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201107262152.23761.szymon@janc.net.pl \
--to=szymon@janc.net.pl \
--cc=linux-bluetooth@vger.kernel.org \
--cc=peter@hurleysoftware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).