* [PATCH] Makefile.am: Mark local_headers as BUILT_SOURCES
@ 2011-07-09 15:10 Tom Rini
2011-07-27 21:48 ` Johan Hedberg
0 siblings, 1 reply; 2+ messages in thread
From: Tom Rini @ 2011-07-09 15:10 UTC (permalink / raw)
To: linux-bluetooth
As these files are auto-generated they need to be marked as BUILT_SOURCES
so that we don't run into a build race later on. lib/bluetooth is removed
by clean-local so this doesn't need to be in CLEAN_FILES
Signed-off-by: Tom Rini <tom_rini@mentor.com>
---
Makefile.am | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/Makefile.am b/Makefile.am
index fab05eb..356b09f 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -53,6 +53,8 @@ lib_headers = lib/bluetooth.h lib/hci.h lib/hci_lib.h lib/mgmt.h \
lib/rfcomm.h lib/bnep.h lib/cmtp.h lib/hidp.h
local_headers = $(foreach file,$(lib_headers), lib/bluetooth/$(notdir $(file)))
+BUILT_SOURCES = $(local_headers)
+
include_HEADERS += $(lib_headers)
lib_LTLIBRARIES += lib/libbluetooth.la
@@ -62,9 +64,6 @@ lib_libbluetooth_la_SOURCES = $(lib_headers) \
lib_libbluetooth_la_LDFLAGS = -version-info 14:3:11
lib_libbluetooth_la_DEPENDENCIES = $(local_headers)
-CLEANFILES += $(local_headers)
-
-
if SBC
noinst_LTLIBRARIES += sbc/libsbc.la
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Makefile.am: Mark local_headers as BUILT_SOURCES
2011-07-09 15:10 [PATCH] Makefile.am: Mark local_headers as BUILT_SOURCES Tom Rini
@ 2011-07-27 21:48 ` Johan Hedberg
0 siblings, 0 replies; 2+ messages in thread
From: Johan Hedberg @ 2011-07-27 21:48 UTC (permalink / raw)
To: Tom Rini; +Cc: linux-bluetooth
Hi Tom,
On Sat, Jul 09, 2011, Tom Rini wrote:
> As these files are auto-generated they need to be marked as BUILT_SOURCES
> so that we don't run into a build race later on. lib/bluetooth is removed
> by clean-local so this doesn't need to be in CLEAN_FILES
> ---
> Makefile.am | 5 ++---
> 1 files changed, 2 insertions(+), 3 deletions(-)
The patch has now (finally) been pushed upstream. Thanks.
Johan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-07-27 21:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-07-09 15:10 [PATCH] Makefile.am: Mark local_headers as BUILT_SOURCES Tom Rini
2011-07-27 21:48 ` Johan Hedberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).