Re: [PATCH] Add watch for RFCOMM disconnect to HFP HF role

[Johan Hedberg <johan.hedberg@gmail.com>]

Hi Frédéric,

On Thu, Aug 04, 2011, Frédéric Dalleau wrote:
> ---
>  audio/gateway.c |   22 ++++++++++++++++++++++
>  1 files changed, 22 insertions(+), 0 deletions(-)
> 
> diff --git a/audio/gateway.c b/audio/gateway.c
> index ec0ec5d..200930f 100644
> --- a/audio/gateway.c
> +++ b/audio/gateway.c
> @@ -188,9 +188,29 @@ static void sco_connect_cb(GIOChannel *chan, GError *err, gpointer user_data)
>  				(GIOFunc) sco_io_cb, dev);
>  }
>  
> +static gboolean rfcomm_disconnect_cb(GIOChannel *chan, GIOCondition cond,
> +			struct audio_device *dev)
> +{
> +	struct gateway *gw = dev->gateway;
> +
> +	if (cond & G_IO_NVAL)
> +		return FALSE;
> +
> +	if (cond & (G_IO_ERR | G_IO_HUP)) {

Since this function is only called for NVAL, ERR and HUP, do you even
need to have this check here. Maybe you could just get rid of this
second if-statement.

Johan