linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH obexd] Add Name header check to ftp_chkput
@ 2011-08-04 12:49 Slawomir Bochenski
  2011-08-04 12:58 ` Johan Hedberg
  0 siblings, 1 reply; 2+ messages in thread
From: Slawomir Bochenski @ 2011-08-04 12:49 UTC (permalink / raw)
  To: linux-bluetooth; +Cc: Slawomir Bochenski

Validation of Name header was missing from ftp_chkput, thus still allowing
actual putting.
---
 plugins/ftp.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/plugins/ftp.c b/plugins/ftp.c
index 57b187c..b0ef540 100644
--- a/plugins/ftp.c
+++ b/plugins/ftp.c
@@ -267,6 +267,9 @@ int ftp_chkput(struct obex_session *os, void *user_data)
 	if (name == NULL)
 		return -EBADR;
 
+	if (!is_filename(name))
+		return -EBADR;
+
 	if (obex_get_size(os) == OBJECT_SIZE_DELETE)
 		return 0;
 
-- 
1.7.4.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH obexd] Add Name header check to ftp_chkput
  2011-08-04 12:49 [PATCH obexd] Add Name header check to ftp_chkput Slawomir Bochenski
@ 2011-08-04 12:58 ` Johan Hedberg
  0 siblings, 0 replies; 2+ messages in thread
From: Johan Hedberg @ 2011-08-04 12:58 UTC (permalink / raw)
  To: Slawomir Bochenski; +Cc: linux-bluetooth

Hi Slawek,

On Thu, Aug 04, 2011, Slawomir Bochenski wrote:
> Validation of Name header was missing from ftp_chkput, thus still allowing
> actual putting.
> ---
>  plugins/ftp.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)

Applied. Thanks.

Johan

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-08-04 12:58 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-04 12:49 [PATCH obexd] Add Name header check to ftp_chkput Slawomir Bochenski
2011-08-04 12:58 ` Johan Hedberg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).